Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLib][FlightSQL] Add support for prepared INSERT #37143

Closed
kou opened this issue Aug 14, 2023 · 0 comments · Fixed by #37196
Closed

[GLib][FlightSQL] Add support for prepared INSERT #37143

kou opened this issue Aug 14, 2023 · 0 comments · Fixed by #37196

Comments

@kou
Copy link
Member

kou commented Aug 14, 2023

Describe the enhancement requested

We need the following functions and classes:

  • gaflightsql_client_prepare()
  • GAFlightSQLPreparedStatement and functions for it.

Component(s)

FlightRPC, GLib

kou added a commit to kou/arrow that referenced this issue Aug 16, 2023
Sorry. This is too large I thought.

Core bindings are the followings:

* `GAFLightSQLPreparedStatement`
* `gaflightsql_client_prepare()`

Others are for writing test of them. We need to implement a test
server for prepared INSERT. Others are for it.

An exception is `ruby/red-arrow-flight-sql/lib/` change. It's for
convenient API for `gaflightsql_client_prepare()`.
kou added a commit to kou/arrow that referenced this issue Aug 16, 2023
Sorry. This is too large I thought.

Core bindings are the followings:

* `GAFLightSQLPreparedStatement`
* `gaflightsql_client_prepare()`

Others are for writing test of them. We need to implement a test
server for prepared INSERT. Others are for it.

An exception is `ruby/red-arrow-flight-sql/lib/` change. It's for
convenient API for `gaflightsql_client_prepare()`.
kou added a commit that referenced this issue Aug 18, 2023
### Rationale for this change

Prepared INSERT is useful for large INSERT.

### What changes are included in this PR?

Sorry. This is too large I thought.

Core bindings are the followings:

* `GAFLightSQLPreparedStatement`
* `gaflightsql_client_prepare()`

Others are for writing test of them. We need to implement a test server for prepared INSERT. Others are for it.

An exception is `ruby/red-arrow-flight-sql/lib/` change. It's for convenient API for `gaflightsql_client_prepare()`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #37143

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 18, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…ache#37196)

### Rationale for this change

Prepared INSERT is useful for large INSERT.

### What changes are included in this PR?

Sorry. This is too large I thought.

Core bindings are the followings:

* `GAFLightSQLPreparedStatement`
* `gaflightsql_client_prepare()`

Others are for writing test of them. We need to implement a test server for prepared INSERT. Others are for it.

An exception is `ruby/red-arrow-flight-sql/lib/` change. It's for convenient API for `gaflightsql_client_prepare()`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37143

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant