GH-37143: [GLib][FlightSQL] Add support for prepared INSERT #37196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sorry. This is too large I thought. Core bindings are the followings: * `GAFLightSQLPreparedStatement` * `gaflightsql_client_prepare()` Others are for writing test of them. We need to implement a test server for prepared INSERT. Others are for it. An exception is `ruby/red-arrow-flight-sql/lib/` change. It's for convenient API for `gaflightsql_client_prepare()`.
kou
force-pushed
the
glib-flight-sql-prepare-insert
branch
from
8d66a59
to
7aae358
Compare
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9fea4ee. There were 4 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…ache#37196) ### Rationale for this change Prepared INSERT is useful for large INSERT. ### What changes are included in this PR? Sorry. This is too large I thought. Core bindings are the followings: * `GAFLightSQLPreparedStatement` * `gaflightsql_client_prepare()` Others are for writing test of them. We need to implement a test server for prepared INSERT. Others are for it. An exception is `ruby/red-arrow-flight-sql/lib/` change. It's for convenient API for `gaflightsql_client_prepare()`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37143 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Prepared INSERT is useful for large INSERT.
What changes are included in this PR?
Sorry. This is too large I thought.
Core bindings are the followings:
GAFLightSQLPreparedStatementgaflightsql_client_prepare()Others are for writing test of them. We need to implement a test server for prepared INSERT. Others are for it.
An exception is
ruby/red-arrow-flight-sql/lib/change. It's for convenient API forgaflightsql_client_prepare().Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.