[MATLAB] Re-implement tfeathermex.m tests in terms of new internal Feather Reader and Writer objects
#37187
Comments
|
take |
kevingurney
pushed a commit
that referenced
this issue
Aug 15, 2023
… internal Feather Reader and Writer objects (#37189) ### Rationale for this change Now that we have new internal Feather V1 `arrow.internal.io.feather.Reader` and `arrow.internal.io.feather.Writer` objects, we can re-implement the `tfeathermex.m` tests in terms of calls to these new internal APIs. As part of this change, we can also move these test cases into `matlab/test/arrow/io/feather/tRoundTrip.m` and delete the old `tfeathermex.m` file. Deleting the old Feather MEX tests will allow us to also delete the old Feather MEX code. ### What changes are included in this PR? 1. Moved test cases `NumericDatatypesNulls` and `InvalidMATLABTableVariableNames` from `test/tfeathermex.m` to `test/arrow/internal/io/feather/tRoundTrip.m` 2. Deleted `test/tfeathermex.m` 3. Deleted obsolete test utility `test/util/createVariablesAndMetadataStructs.m` 4. Deleted obsolete test utility `test/util/featherMEXRoundTrip.m` ### Are these changes tested? Yes. All tests pass. ### Are there any user-facing changes? No. ### Future Directions 1. Delete the MEX source code from the interface. 2. Move `test/util/createTable.m` and `test/util/featherRoundTrip.m` into package functions underneath `arrow.internal.test.*` (See #37188) * Closes: #37187 Authored-by: Sarah Gilmore <sgilmore@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…of new internal Feather Reader and Writer objects (apache#37189) ### Rationale for this change Now that we have new internal Feather V1 `arrow.internal.io.feather.Reader` and `arrow.internal.io.feather.Writer` objects, we can re-implement the `tfeathermex.m` tests in terms of calls to these new internal APIs. As part of this change, we can also move these test cases into `matlab/test/arrow/io/feather/tRoundTrip.m` and delete the old `tfeathermex.m` file. Deleting the old Feather MEX tests will allow us to also delete the old Feather MEX code. ### What changes are included in this PR? 1. Moved test cases `NumericDatatypesNulls` and `InvalidMATLABTableVariableNames` from `test/tfeathermex.m` to `test/arrow/internal/io/feather/tRoundTrip.m` 2. Deleted `test/tfeathermex.m` 3. Deleted obsolete test utility `test/util/createVariablesAndMetadataStructs.m` 4. Deleted obsolete test utility `test/util/featherMEXRoundTrip.m` ### Are these changes tested? Yes. All tests pass. ### Are there any user-facing changes? No. ### Future Directions 1. Delete the MEX source code from the interface. 2. Move `test/util/createTable.m` and `test/util/featherRoundTrip.m` into package functions underneath `arrow.internal.test.*` (See apache#37188) * Closes: apache#37187 Authored-by: Sarah Gilmore <sgilmore@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Now that we have new internal Feather V1
arrow.internal.io.feather.Readerandarrow.internal.io.feather.Writerobjects, we can re-implement thetfeathermex.mtests in terms of calls to these new internal APIs. As part of this change, we can also move these test cases intomatlab/test/arrow/io/feather/tRoundTrip.mand delete the oldtfeathermex.mfile. Deleting the old Feather MEX tests will allow us to also delete the old Feather MEX code.Component(s)
MATLAB
The text was updated successfully, but these errors were encountered: