Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] Move test/util/featherRoundTrip.m into a packaged test utility function #37188

Closed
kevingurney opened this issue Aug 15, 2023 · 0 comments · Fixed by #37190
Closed

[MATLAB] Move test/util/featherRoundTrip.m into a packaged test utility function #37188

kevingurney opened this issue Aug 15, 2023 · 0 comments · Fixed by #37190
Assignees
@kevingurney
Labels
Component: MATLAB Type: enhancement
Milestone
14.0.0

Comments

@kevingurney
Copy link
Member

Describe the enhancement requested

In order to simplify access to the featherRoundTrip function that is used in the tfeather.m tests, it would be helpful to move it into a packaged test utility function. This would make it possible toimport the function, rather than having to manually add the test/util folder to the MATLAB Search Path in the test class setup.

An example name for the new packaged test utility function is: arrow.internal.test.io.feather.roundtrip.

Component(s)

MATLAB
@kevingurney kevingurney changed the title Move test/util/featherRoundTrip.m into a packaged test utility Move test/util/featherRoundTrip.m into a packaged test utility function Aug 15, 2023
@kevingurney kevingurney self-assigned this Aug 15, 2023
@sgilmore10 sgilmore10 mentioned this issue Aug 15, 2023
Merged
@github-actions github-actions bot mentioned this issue Aug 15, 2023
Merged
kevingurney pushed a commit that referenced this issue Aug 15, 2023
@sgilmore10
GH-37187: [MATLAB] Re-implement tfeathermex.m tests in terms of new…
7c8c2fb 
… internal Feather Reader and Writer objects (#37189)

### Rationale for this change

Now that we have new internal Feather V1 `arrow.internal.io.feather.Reader` and `arrow.internal.io.feather.Writer` objects, we can re-implement the `tfeathermex.m` tests in terms of calls to these new internal APIs. As part of this change, we can also move these test cases into `matlab/test/arrow/io/feather/tRoundTrip.m` and delete the old `tfeathermex.m` file. Deleting the old Feather MEX tests will allow us to also delete the old Feather MEX code.

### What changes are included in this PR?

1. Moved test cases `NumericDatatypesNulls` and `InvalidMATLABTableVariableNames` from `test/tfeathermex.m` to `test/arrow/internal/io/feather/tRoundTrip.m`
2. Deleted `test/tfeathermex.m`
3. Deleted obsolete test utility `test/util/createVariablesAndMetadataStructs.m`
4. Deleted obsolete test utility `test/util/featherMEXRoundTrip.m`

### Are these changes tested?

Yes. All tests pass.

### Are there any user-facing changes?

No.

### Future Directions

1. Delete the MEX source code from the interface.
2. Move `test/util/createTable.m` and `test/util/featherRoundTrip.m` into package functions underneath `arrow.internal.test.*` (See #37188)
* Closes: #37187

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
@kou kou changed the title Move test/util/featherRoundTrip.m into a packaged test utility function [MATLAB] Move test/util/featherRoundTrip.m into a packaged test utility function Aug 15, 2023
kevingurney added a commit that referenced this issue Aug 16, 2023
@kevingurney
GH-37188: [MATLAB] Move test/util/featherRoundTrip.m into a package…
d330d1b 
…d test utility function (#37190)

> **Warning** - Please don't merge this PR. It is still in progress.

### Rationale for this change

To simplify access to the `featherRoundTrip` function that is used in the `tfeather.m` tests this pull request moves the `featherRoundTrip` code into a new packaged test utility function `arrow.internal.test.io.feather.roundtrip`.

This makes it possible to`import` the function, rather than having to manually add the `test/util` folder to the MATLAB Search Path in the test class setup.

### What changes are included in this PR?

1. Moved `test/util/featherRoundTrip.m` code into a new internal packaged test utility function `arrow.internal.test.io.feather.roundtrip`.

### Are these changes tested?

Yes.

1. Updated all `tfeather.m` test cases to use new packaged function `arrow.internal.test.io.feather.roundtrip`.

### Are there any user-facing changes?

No.

This new packaged function is an internal test utility.

### Future Directions

1. Delete the old Feather MEX code.
2. Move more shared test infrastructure into packaged test functions under `arrow.internal.test.*`.
* Closes: #37188

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
@kevingurney kevingurney added this to the 14.0.0 milestone Aug 16, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@sgilmore10 @loicalleyne
apacheGH-37187: [MATLAB] Re-implement tfeathermex.m tests in terms …
25a0fee 
…of new internal Feather Reader and Writer objects (apache#37189)

### Rationale for this change

Now that we have new internal Feather V1 `arrow.internal.io.feather.Reader` and `arrow.internal.io.feather.Writer` objects, we can re-implement the `tfeathermex.m` tests in terms of calls to these new internal APIs. As part of this change, we can also move these test cases into `matlab/test/arrow/io/feather/tRoundTrip.m` and delete the old `tfeathermex.m` file. Deleting the old Feather MEX tests will allow us to also delete the old Feather MEX code.

### What changes are included in this PR?

1. Moved test cases `NumericDatatypesNulls` and `InvalidMATLABTableVariableNames` from `test/tfeathermex.m` to `test/arrow/internal/io/feather/tRoundTrip.m`
2. Deleted `test/tfeathermex.m`
3. Deleted obsolete test utility `test/util/createVariablesAndMetadataStructs.m`
4. Deleted obsolete test utility `test/util/featherMEXRoundTrip.m`

### Are these changes tested?

Yes. All tests pass.

### Are there any user-facing changes?

No.

### Future Directions

1. Delete the MEX source code from the interface.
2. Move `test/util/createTable.m` and `test/util/featherRoundTrip.m` into package functions underneath `arrow.internal.test.*` (See apache#37188)
* Closes: apache#37187

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kevingurney @loicalleyne
apacheGH-37188: [MATLAB] Move test/util/featherRoundTrip.m into a p…
c4b32bb 
…ackaged test utility function (apache#37190)

> **Warning** - Please don't merge this PR. It is still in progress.

### Rationale for this change

To simplify access to the `featherRoundTrip` function that is used in the `tfeather.m` tests this pull request moves the `featherRoundTrip` code into a new packaged test utility function `arrow.internal.test.io.feather.roundtrip`.

This makes it possible to`import` the function, rather than having to manually add the `test/util` folder to the MATLAB Search Path in the test class setup.

### What changes are included in this PR?

1. Moved `test/util/featherRoundTrip.m` code into a new internal packaged test utility function `arrow.internal.test.io.feather.roundtrip`.

### Are these changes tested?

Yes.

1. Updated all `tfeather.m` test cases to use new packaged function `arrow.internal.test.io.feather.roundtrip`.

### Are there any user-facing changes?

No.

This new packaged function is an internal test utility.

### Future Directions

1. Delete the old Feather MEX code.
2. Move more shared test infrastructure into packaged test functions under `arrow.internal.test.*`.
* Closes: apache#37188

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevingurney kevingurney

Labels
Component: MATLAB Type: enhancement
Projects
None yet
Milestone
14.0.0
1 participant
@kevingurney