Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Many "DOWNLOAD_EXTRACT_TIMESTAMP option was not given" warnings #37237

Closed
kou opened this issue Aug 18, 2023 · 0 comments · Fixed by #37238
Closed

[C++] Many "DOWNLOAD_EXTRACT_TIMESTAMP option was not given" warnings #37237

kou opened this issue Aug 18, 2023 · 0 comments · Fixed by #37238

Comments

@kou
Copy link
Member

kou commented Aug 18, 2023

Describe the enhancement requested

We get many the following warnings with CMake 3.27:

CMake Warning (dev) at /usr/share/cmake-3.27/Modules/ExternalProject.cmake:3136 (message):
  The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
  not set.  The policy's OLD behavior will be used.  When using a URL
  download, the timestamps of extracted files should preferably be that of
  the time of extraction, otherwise code that depends on the extracted
  contents might not be rebuilt if the URL changes.  The OLD behavior
  preserves the timestamps from the archive instead, but this is usually not
  what you want.  Update your project to the NEW behavior or specify the
  DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this
  robustness issue.

Component(s)

C++

kou added a commit to kou/arrow that referenced this issue Aug 18, 2023
kou added a commit to kou/arrow that referenced this issue Aug 26, 2023
kou added a commit that referenced this issue Aug 29, 2023
…amp (#37238)

### Rationale for this change

The "The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is not set." warnings are noisy.

### What changes are included in this PR?

Set `CMP0135` policy.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #37237

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 29, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…timestamp (apache#37238)

### Rationale for this change

The "The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is not set." warnings are noisy.

### What changes are included in this PR?

Set `CMP0135` policy.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37237

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant