Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby][FlightSQL] Arrow::Flight::CallOptions isn't used for auto prepared statement close request #37257

Closed
kou opened this issue Aug 18, 2023 · 0 comments · Fixed by #37258
Closed

Comments

@kou
Copy link
Member

kou commented Aug 18, 2023

Describe the enhancement requested

options = ArrowFlight::CallOptions.new
sql_client.prepare("... SQL ...", options) do |statement|
  # ...
  # statement.close is called automatically without the "options" but
  # the "options" is used like statement.close(options).
end

Component(s)

FlightRPC, Ruby

@kou kou changed the title [Ruby][FlightSQL] Arrow::Flight::CallOptions isn't used for auto prepared close request [Ruby][FlightSQL] Arrow::Flight::CallOptions isn't used for auto prepared statement close request Aug 18, 2023
kou added a commit to kou/arrow that referenced this issue Aug 18, 2023
kou added a commit to kou/arrow that referenced this issue Aug 18, 2023
kou added a commit to kou/arrow that referenced this issue Aug 18, 2023
kou added a commit that referenced this issue Aug 23, 2023
…atement close request (#37258)

### Rationale for this change

If we don't pass the same options for auto prepared statement close request, the close request may be failed.
For example, it's caused when authentication information in the options. 

### What changes are included in this PR?

`ArrowFlightSQL::Client#prepare` change is the main change to use the given options for auto prepared statement close  request too.

Other changes (`gaflight_server_call_context_foreach_incoming_header()` and related changes) are for testing the above change.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #37257

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 23, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…red statement close request (apache#37258)

### Rationale for this change

If we don't pass the same options for auto prepared statement close request, the close request may be failed.
For example, it's caused when authentication information in the options. 

### What changes are included in this PR?

`ArrowFlightSQL::Client#prepare` change is the main change to use the given options for auto prepared statement close  request too.

Other changes (`gaflight_server_call_context_foreach_incoming_header()` and related changes) are for testing the above change.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37257

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant