GH-37257: [Ruby][FlightSQL] Use the same options for auto prepared statement close request #37258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red statement close request
|
|
github-actions
bot
added
Component: Ruby
Component: GLib
awaiting committer review
|
+1 |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 7da0bff. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…red statement close request (apache#37258) ### Rationale for this change If we don't pass the same options for auto prepared statement close request, the close request may be failed. For example, it's caused when authentication information in the options. ### What changes are included in this PR? `ArrowFlightSQL::Client#prepare` change is the main change to use the given options for auto prepared statement close request too. Other changes (`gaflight_server_call_context_foreach_incoming_header()` and related changes) are for testing the above change. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37257 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If we don't pass the same options for auto prepared statement close request, the close request may be failed.
For example, it's caused when authentication information in the options.
What changes are included in this PR?
ArrowFlightSQL::Client#preparechange is the main change to use the given options for auto prepared statement close request too.Other changes (
gaflight_server_call_context_foreach_incoming_header()and related changes) are for testing the above change.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.