Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Docs] cpp-tutorial-example fails building #37308

Closed
pitrou opened this issue Aug 22, 2023 · 3 comments · Fixed by #37311
Closed

[C++][Docs] cpp-tutorial-example fails building #37308

pitrou opened this issue Aug 22, 2023 · 3 comments · Fixed by #37311
Assignees
@raulcd
Labels
Component: C++ Component: Documentation Type: bug
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Aug 22, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The cpp-tutorial-example Crossbow task fails building, as seen here:
https://github.com/ursacomputing/crossbow/actions/runs/5937066578

Component(s)

C++, Documentation
@pitrou
Copy link
Member Author

pitrou commented Aug 22, 2023

Also this task doesn't seem to be run as part of the nightly builds, which is why we didn't notice it breaking.

@pitrou
Copy link
Member Author

pitrou commented Aug 22, 2023

cc @kou @raulcd @ksuarez1423

@raulcd
Copy link
Member

raulcd commented Aug 22, 2023

Also this task doesn't seem to be run as part of the nightly builds, which is why we didn't notice it breaking.

We should probably rename it to example-cpp-tutorial so it's run as part of the nightly tests along with the rest of example-* tasks: https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml#L164

raulcd added a commit to raulcd/arrow that referenced this issue Aug 22, 2023
@raulcd
apacheGH-37308: [C++][Doc] Change name for CPP tutorial and minor fix…
53366ef 
…es to the job
@github-actions github-actions bot mentioned this issue Aug 22, 2023
Merged
@kou kou changed the title [C++][Doc] cpp-tutorial-example fails building [C++][Docs] cpp-tutorial-example fails building Aug 22, 2023
kou added a commit that referenced this issue Aug 25, 2023
@raulcd @kou
GH-37308: [C++][Docs] Change name for CPP tutorial and minor fixes to…
86b7a84 
… the job (#37311)

### Rationale for this change

Fix the job and rename so it's picked up as part of the nightlies

### What changes are included in this PR?

Rename + fixes to the job.

### Are these changes tested?

Via CI

### Are there any user-facing changes?

No
* Closes: #37308

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 25, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@raulcd @kou @loicalleyne
apacheGH-37308: [C++][Docs] Change name for CPP tutorial and minor fi…
b074335 
…xes to the job (apache#37311)

### Rationale for this change

Fix the job and rename so it's picked up as part of the nightlies

### What changes are included in this PR?

Rename + fixes to the job.

### Are these changes tested?

Via CI

### Are there any user-facing changes?

No
* Closes: apache#37308

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: C++ Component: Documentation Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37308: [C++][Docs] Change name for CPP tutorial and minor fixes to the job raulcd/arrow
3 participants
@kou @raulcd @pitrou