Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37308: [C++][Docs] Change name for CPP tutorial and minor fixes to the job #37311

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Aug 22, 2023

Rationale for this change

Fix the job and rename so it's picked up as part of the nightlies

What changes are included in this PR?

Rename + fixes to the job.

Are these changes tested?

Via CI

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #37308 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Aug 22, 2023

@github-actions crossbow submit example-cpp-tutorial

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 22, 2023
@github-actions
Copy link

Revision: 53366ef

Submitted crossbow builds: ursacomputing/crossbow @ actions-105eb52af0

Task Status
example-cpp-tutorial Github Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Aug 22, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 22, 2023
@raulcd raulcd marked this pull request as ready for review August 22, 2023 16:37
@kou kou changed the title GH-37308: [C++][Doc] Change name for CPP tutorial and minor fixes to the job GH-37308: [C++][Docs] Change name for CPP tutorial and minor fixes to the job Aug 22, 2023
cpp/examples/tutorial_examples/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/examples/tutorial_examples/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/examples/tutorial_examples/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/examples/tutorial_examples/run.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 22, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 23, 2023
@raulcd
Copy link
Member Author

raulcd commented Aug 23, 2023

@github-actions crossbow submit example-cpp-tutorial

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 23, 2023
@github-actions
Copy link

Revision: 99621ca

Submitted crossbow builds: ursacomputing/crossbow @ actions-3d22c75dd7

Task Status
example-cpp-tutorial Github Actions

cpp/examples/tutorial_examples/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/examples/tutorial_examples/run.sh Outdated Show resolved Hide resolved
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 24, 2023
@raulcd
Copy link
Member Author

raulcd commented Aug 24, 2023

@github-actions crossbow submit example-cpp-tutorial

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 24, 2023
@github-actions
Copy link

Revision: bd1320d

Submitted crossbow builds: ursacomputing/crossbow @ actions-129a1b3ce9

Task Status
example-cpp-tutorial Github Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 86b7a84 into apache:main Aug 25, 2023
32 of 34 checks passed
@kou kou removed the awaiting changes Awaiting changes label Aug 25, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Aug 25, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 86b7a84.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…xes to the job (apache#37311)

### Rationale for this change

Fix the job and rename so it's picked up as part of the nightlies

### What changes are included in this PR?

Rename + fixes to the job.

### Are these changes tested?

Via CI

### Are there any user-facing changes?

No
* Closes: apache#37308

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][Docs] cpp-tutorial-example fails building
2 participants