[C++] libdata/pkgconfig/arrow-compute.pc is installed when COMPUTE is disabled with -DARROW_COMPUTE=FALSE #37408
Comments
|
Could you show all your |
|
Ah, sorry. It's not needed. I could reproduce this. |
kou
changed the title
kou
added a commit
to kou/arrow
that referenced
this issue
Aug 27, 2023
kou
added a commit
that referenced
this issue
Aug 29, 2023
…37409) ### Rationale for this change GH-34295 changed meaning of `ARROW_COMPUTE`. `ARROW_COMPUTE=ON` means that "all compute kerenels are enabled" not "compute module is enabled". `arrow-compute.pc` is for detecting `ARROW_COMPUTE`. So `arrow-compute.pc` should be installed only when `ARROW_COMPUTE=ON`. ### What changes are included in this PR? Add missing `if (ARROW_COMPUTE)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #37408 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…E=ON (apache#37409) ### Rationale for this change apacheGH-34295 changed meaning of `ARROW_COMPUTE`. `ARROW_COMPUTE=ON` means that "all compute kerenels are enabled" not "compute module is enabled". `arrow-compute.pc` is for detecting `ARROW_COMPUTE`. So `arrow-compute.pc` should be installed only when `ARROW_COMPUTE=ON`. ### What changes are included in this PR? Add missing `if (ARROW_COMPUTE)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37408 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…E=ON (apache#37409) ### Rationale for this change apacheGH-34295 changed meaning of `ARROW_COMPUTE`. `ARROW_COMPUTE=ON` means that "all compute kerenels are enabled" not "compute module is enabled". `arrow-compute.pc` is for detecting `ARROW_COMPUTE`. So `arrow-compute.pc` should be installed only when `ARROW_COMPUTE=ON`. ### What changes are included in this PR? Add missing `if (ARROW_COMPUTE)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37408 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
Version: 13.0.0
FreeBSD 13.2
Component(s)
C++
The text was updated successfully, but these errors were encountered: