GH-37408: [C++] Install arrow-compute.pc only when ARROW_COMPUTE=ON #37409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5720f7c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…E=ON (apache#37409) ### Rationale for this change apacheGH-34295 changed meaning of `ARROW_COMPUTE`. `ARROW_COMPUTE=ON` means that "all compute kerenels are enabled" not "compute module is enabled". `arrow-compute.pc` is for detecting `ARROW_COMPUTE`. So `arrow-compute.pc` should be installed only when `ARROW_COMPUTE=ON`. ### What changes are included in this PR? Add missing `if (ARROW_COMPUTE)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37408 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…E=ON (apache#37409) ### Rationale for this change apacheGH-34295 changed meaning of `ARROW_COMPUTE`. `ARROW_COMPUTE=ON` means that "all compute kerenels are enabled" not "compute module is enabled". `arrow-compute.pc` is for detecting `ARROW_COMPUTE`. So `arrow-compute.pc` should be installed only when `ARROW_COMPUTE=ON`. ### What changes are included in this PR? Add missing `if (ARROW_COMPUTE)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37408 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GH-34295 changed meaning of
ARROW_COMPUTE.ARROW_COMPUTE=ONmeans that "all compute kerenels are enabled" not "compute module is enabled".arrow-compute.pcis for detectingARROW_COMPUTE. Soarrow-compute.pcshould be installed only whenARROW_COMPUTE=ON.What changes are included in this PR?
Add missing
if (ARROW_COMPUTE).Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.