You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our source code should not have "#include"s that depend on
source/binary directories exists in include path.
This also fixes that CUDA's cuda.h isn't included problem.
### Rationale for this change
Our source code should not have "#include"s that depend on source/binary directories exists in include path.
This also fixes that CUDA's cuda.h isn't included problem.
### What changes are included in this PR?
Don't use implicit include directories.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* Closes: #37507
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…#37508)
### Rationale for this change
Our source code should not have "#include"s that depend on source/binary directories exists in include path.
This also fixes that CUDA's cuda.h isn't included problem.
### What changes are included in this PR?
Don't use implicit include directories.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* Closes: apache#37507
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…#37508)
### Rationale for this change
Our source code should not have "#include"s that depend on source/binary directories exists in include path.
This also fixes that CUDA's cuda.h isn't included problem.
### What changes are included in this PR?
Don't use implicit include directories.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* Closes: apache#37507
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the bug, including details regarding any error messages, version, and platform.
https://github.com/apache/arrow/blob/main/c_glib/arrow-cuda-glib/cuda.h not CUDA's
cuda.h
is included forarrow/cpp/src/arrow/gpu/cuda_context.h
Line 24 in b6c0ea4
test-ubuntu-22.04-docs
https://github.com/ursacomputing/crossbow/actions/runs/6034388088/job/16372666129#step:7:8241
Component(s)
GLib, GPU
The text was updated successfully, but these errors were encountered: