Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Bundled Azure SDK for C++ should not be installed #37510

Closed
kou opened this issue Sep 1, 2023 · 0 comments · Fixed by #38176
Closed

[C++] Bundled Azure SDK for C++ should not be installed #37510

kou opened this issue Sep 1, 2023 · 0 comments · Fixed by #38176
Assignees
@kou
Labels
Component: C++ Priority: Blocker Marks a blocker for the release Type: enhancement
Milestone
14.0.0

Comments

@kou
Copy link
Member

kou commented Sep 1, 2023

Describe the enhancement requested

libazure-*.a such as libazure-core.a should not be installed. They must be included in libarrow_bundled_dependencies.a.

Component(s)

C++
@kou kou added the Priority: Blocker Marks a blocker for the release label Sep 20, 2023
kou added a commit to kou/arrow that referenced this issue Oct 10, 2023
@kou
apacheGH-37510: [C++] Don't install bundled Azure SDK for C++
672a524
kou added a commit to kou/arrow that referenced this issue Oct 10, 2023
@kou
apacheGH-37510: [C++] Don't install bundled Azure SDK for C++
a68f554
@github-actions github-actions bot mentioned this issue Oct 10, 2023
Merged
@ianmcook ianmcook added this to the 14.0.0 milestone Oct 10, 2023
kou added a commit to kou/arrow that referenced this issue Oct 11, 2023
@kou
apacheGH-37510: [C++] Don't install bundled Azure SDK for C++
096b360
kou added a commit that referenced this issue Oct 11, 2023
@kou
GH-37510: [C++] Don't install bundled Azure SDK for C++ (#38176)
7047e63 
### Rationale for this change

It's an internal bundled library. We should not install it as a part of Arrow.

### What changes are included in this PR?

Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #37510

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
raulcd pushed a commit that referenced this issue Oct 12, 2023
@kou @raulcd
GH-37510: [C++] Don't install bundled Azure SDK for C++ (#38176)
2fad064 
### Rationale for this change

It's an internal bundled library. We should not install it as a part of Arrow.

### What changes are included in this PR?

Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #37510

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
llama90 pushed a commit to llama90/arrow that referenced this issue Oct 12, 2023
@kou @llama90
apacheGH-37510: [C++] Don't install bundled Azure SDK for C++ (apache…
274c621 
…#38176)

### Rationale for this change

It's an internal bundled library. We should not install it as a part of Arrow.

### What changes are included in this PR?

Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37510

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@kou
apacheGH-37510: [C++] Don't install bundled Azure SDK for C++ (apache…
59c9327 
…#38176)

### Rationale for this change

It's an internal bundled library. We should not install it as a part of Arrow.

### What changes are included in this PR?

Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37510

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-37510: [C++] Don't install bundled Azure SDK for C++ (apache…
82e9f91 
…#38176)

### Rationale for this change

It's an internal bundled library. We should not install it as a part of Arrow.

### What changes are included in this PR?

Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37510

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou mentioned this issue Dec 18, 2023
Closed
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-37510: [C++] Don't install bundled Azure SDK for C++ (apache…
de1dd69 
…#38176)

### Rationale for this change

It's an internal bundled library. We should not install it as a part of Arrow.

### What changes are included in this PR?

Exclude all Azure SDK for C++ jobs including install jobs aren't executed by default. Building jobs are executed because they are required to build Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37510

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Priority: Blocker Marks a blocker for the release Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37510: [C++] Don't install bundled Azure SDK for C++ kou/arrow
2 participants
@kou @ianmcook