Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Don't install bundled Azure SDK for C++ with CMake 3.28+ #39268

Closed
kou opened this issue Dec 18, 2023 · 0 comments · Fixed by #39269
Closed

[C++] Don't install bundled Azure SDK for C++ with CMake 3.28+ #39268

kou opened this issue Dec 18, 2023 · 0 comments · Fixed by #39269

Comments

@kou
Copy link
Member

kou commented Dec 18, 2023

Describe the enhancement requested

It's related to #37510.
We don't install bundled Azure SDK for C++ with CMake < 3.28 with #38176.
We need to enable

Component(s)

C++

kou added a commit to kou/arrow that referenced this issue Dec 18, 2023
…ake 3.28+

We can implement this by specifying `EXCLUDE_FROM_ALL TRUE` to
`fetchcontent_declare()`.
kou added a commit to kou/arrow that referenced this issue Dec 18, 2023
…ake 3.28+

We can implement this by specifying `EXCLUDE_FROM_ALL TRUE` to
`fetchcontent_declare()`.
@kou kou closed this as completed in #39269 Jan 1, 2024
kou added a commit that referenced this issue Jan 1, 2024
…28+ (#39269)

### Rationale for this change

We can implement this by specifying `EXCLUDE_FROM_ALL TRUE` to `fetchcontent_declare()`.

### What changes are included in this PR?

Specify `EXCLUDE_FROM_ALL TRUE` only with CMake 3.28+.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #39268

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Jan 1, 2024
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
…ake 3.28+ (apache#39269)

### Rationale for this change

We can implement this by specifying `EXCLUDE_FROM_ALL TRUE` to `fetchcontent_declare()`.

### What changes are included in this PR?

Specify `EXCLUDE_FROM_ALL TRUE` only with CMake 3.28+.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39268

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…ake 3.28+ (apache#39269)

### Rationale for this change

We can implement this by specifying `EXCLUDE_FROM_ALL TRUE` to `fetchcontent_declare()`.

### What changes are included in this PR?

Specify `EXCLUDE_FROM_ALL TRUE` only with CMake 3.28+.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39268

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
…ake 3.28+ (apache#39269)

### Rationale for this change

We can implement this by specifying `EXCLUDE_FROM_ALL TRUE` to `fetchcontent_declare()`.

### What changes are included in this PR?

Specify `EXCLUDE_FROM_ALL TRUE` only with CMake 3.28+.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39268

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant