[C++] Migrate JSON Integration code to Result<> #37567
Comments
pitrou
added a commit
to pitrou/arrow
that referenced
this issue
Sep 5, 2023
pitrou
added a commit
that referenced
this issue
Sep 5, 2023
### Rationale for this change The JSON Integration APIs still use the old-style of returning `Status` together with a `T*` out-parameter. While those are internal APIs, it would still improve ease of us to migrate them to the newer idiom of returning a `Result<T>`. ### What changes are included in this PR? Migrate the relevant APIs from `Status` to `Result`. Since the APIs are internal, no deprecation period is introduced. Also, some very minor style and testing cleanups here and there. ### Are these changes tested? By existing tests. ### Are there any user-facing changes? No. * Closes: #37567 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…he#37573) ### Rationale for this change The JSON Integration APIs still use the old-style of returning `Status` together with a `T*` out-parameter. While those are internal APIs, it would still improve ease of us to migrate them to the newer idiom of returning a `Result<T>`. ### What changes are included in this PR? Migrate the relevant APIs from `Status` to `Result`. Since the APIs are internal, no deprecation period is introduced. Also, some very minor style and testing cleanups here and there. ### Are these changes tested? By existing tests. ### Are there any user-facing changes? No. * Closes: apache#37567 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…he#37573) ### Rationale for this change The JSON Integration APIs still use the old-style of returning `Status` together with a `T*` out-parameter. While those are internal APIs, it would still improve ease of us to migrate them to the newer idiom of returning a `Result<T>`. ### What changes are included in this PR? Migrate the relevant APIs from `Status` to `Result`. Since the APIs are internal, no deprecation period is introduced. Also, some very minor style and testing cleanups here and there. ### Are these changes tested? By existing tests. ### Are there any user-facing changes? No. * Closes: apache#37567 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
The JSON Integration code is not a public API, so this was overlooked. Nevertheless, migrating to
Result-returning APIs will make it easier to use for us.Component(s)
C++
The text was updated successfully, but these errors were encountered: