GH-37567: [C++] Migrate JSON Integration code to Result<> #37573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
requested review from
assignUser,
kou,
raulcd and
lidavidm
as code owners
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
lidavidm
approved these changes
Sep 5, 2023
dev/archery/archery/cli.py
Outdated
| @@ -764,6 +764,10 @@ def integration(with_all=False, random_seed=12345, **args): | |||
| enabled_languages += 1 | |||
|
|
|||
| if gen_path: | |||
| # XXX this option is only used by the JS test suite. | |||
github-actions
bot
added
awaiting merge
bkietz
reviewed
Sep 5, 2023
|
|
||
| private: | ||
| IntegrationJsonReader(MemoryPool* pool, const std::shared_ptr<Buffer>& data); | ||
| IntegrationJsonReader(MemoryPool* pool, std::shared_ptr<Buffer> data); |
There was a problem hiding this comment.
Not for this PR, but food for future thought: a pattern which maintains access control for the constructor but enables usage of factories like make_unique is the private tag:
Suggested change
| IntegrationJsonReader(MemoryPool* pool, std::shared_ptr<Buffer> data); | |
| private: | |
| class Tag { | |
| Tag() = default; | |
| friend class IntegrationJsonReader; | |
| }; | |
| public: | |
| IntegrationJsonReader(Tag, MemoryPool* pool, std::shared_ptr<Buffer> data); |
... probably not worth the boilerplate
There was a problem hiding this comment.
Ha. Yes, I suppose it might be nice for heavily-used public classes, but that's a lot of boilerplate for a small convenience.
bkietz
approved these changes
Sep 5, 2023
github-actions
bot
added
awaiting changes
|
CI failure is unrelated. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d5cc9d9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…he#37573) ### Rationale for this change The JSON Integration APIs still use the old-style of returning `Status` together with a `T*` out-parameter. While those are internal APIs, it would still improve ease of us to migrate them to the newer idiom of returning a `Result<T>`. ### What changes are included in this PR? Migrate the relevant APIs from `Status` to `Result`. Since the APIs are internal, no deprecation period is introduced. Also, some very minor style and testing cleanups here and there. ### Are these changes tested? By existing tests. ### Are there any user-facing changes? No. * Closes: apache#37567 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…he#37573) ### Rationale for this change The JSON Integration APIs still use the old-style of returning `Status` together with a `T*` out-parameter. While those are internal APIs, it would still improve ease of us to migrate them to the newer idiom of returning a `Result<T>`. ### What changes are included in this PR? Migrate the relevant APIs from `Status` to `Result`. Since the APIs are internal, no deprecation period is introduced. Also, some very minor style and testing cleanups here and there. ### Are these changes tested? By existing tests. ### Are there any user-facing changes? No. * Closes: apache#37567 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The JSON Integration APIs still use the old-style of returning
Statustogether with aT*out-parameter.While those are internal APIs, it would still improve ease of us to migrate them to the newer idiom of returning a
Result<T>.What changes are included in this PR?
Migrate the relevant APIs from
StatustoResult. Since the APIs are internal, no deprecation period is introduced.Also, some very minor style and testing cleanups here and there.
Are these changes tested?
By existing tests.
Are there any user-facing changes?
No.