Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Add ValueLen function to string array #37584

Closed
brancz opened this issue Sep 6, 2023 · 2 comments · Fixed by #37586
Closed

[Go] Add ValueLen function to string array #37584

brancz opened this issue Sep 6, 2023 · 2 comments · Fixed by #37586
Assignees
@brancz
Labels
Component: Go Type: enhancement
Milestone
14.0.0

Comments

@brancz
Copy link
Contributor

brancz commented Sep 6, 2023

Describe the enhancement requested

The binary array already has this function, and it's a useful mechanism when all one needs is the length of a value and not the value itself (for pre-allocation of a new buffer for example).

Happy to do the PR for it.

Component(s)

Go
@zeroshade
Copy link
Member

seems reasonable to me, looking forward to the PR, thanks!

@brancz
Copy link
Contributor Author

brancz commented Sep 6, 2023

Here it is: #37586

@github-actions github-actions bot mentioned this issue Sep 6, 2023
Merged
zeroshade pushed a commit that referenced this issue Sep 6, 2023
@brancz
GH-37584: [Go] Add value len function to string array (#37586)
5cd140b 
### Rationale for this change

The binary array already has this function, and it's a useful mechanism when all one needs is the length of a value and not the value itself (for pre-allocation of a new buffer for example).

### What changes are included in this PR?

Add function to return only the length of the string at index position `i`.

### Are these changes tested?

Yes tested by including this in https://parca.dev/

### Are there any user-facing changes?

This is a new API mirroring the same API that already exists on the binary array.
* Closes: #37584

Authored-by: Frederic Branczyk <fbranczyk@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 14.0.0 milestone Sep 6, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@brancz @loicalleyne
apacheGH-37584: [Go] Add value len function to string array (apache#3…
139f5f9 
…7586)

### Rationale for this change

The binary array already has this function, and it's a useful mechanism when all one needs is the length of a value and not the value itself (for pre-allocation of a new buffer for example).

### What changes are included in this PR?

Add function to return only the length of the string at index position `i`.

### Are these changes tested?

Yes tested by including this in https://parca.dev/

### Are there any user-facing changes?

This is a new API mirroring the same API that already exists on the binary array.
* Closes: apache#37584

Authored-by: Frederic Branczyk <fbranczyk@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@brancz @dgreiss
apacheGH-37584: [Go] Add value len function to string array (apache#3…
117273f 
…7586)

### Rationale for this change

The binary array already has this function, and it's a useful mechanism when all one needs is the length of a value and not the value itself (for pre-allocation of a new buffer for example).

### What changes are included in this PR?

Add function to return only the length of the string at index position `i`.

### Are these changes tested?

Yes tested by including this in https://parca.dev/

### Are there any user-facing changes?

This is a new API mirroring the same API that already exists on the binary array.
* Closes: apache#37584

Authored-by: Frederic Branczyk <fbranczyk@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brancz brancz

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37584: [Go] Add value len function to string array brancz/arrow
2 participants
@zeroshade @brancz