Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][CI] Nightly verification tasks are failing with syntax error on thrift #37738

Closed
raulcd opened this issue Sep 15, 2023 · 4 comments · Fixed by #37745
Closed

[Go][CI] Nightly verification tasks are failing with syntax error on thrift #37738

raulcd opened this issue Sep 15, 2023 · 4 comments · Fixed by #37745
Assignees
@zeroshade
Labels
Component: Continuous Integration Component: Go Type: bug
Milestone
14.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Sep 15, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Several nightly verification tasks:

are failing with:

 # github.com/apache/thrift/lib/go/thrift
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/deserializer.go:83:12: syntax error: unexpected [, expecting semicolon or newline or }
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pointerize.go:24:13: syntax error: unexpected [, expecting (
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:28:13: syntax error: unexpected any, expecting ]
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:30:16: syntax error: unexpected newline, expecting name or (
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:31:1: syntax error: non-declaration statement outside function body
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:38:13: syntax error: unexpected [, expecting (
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:38:37: method has no receiver
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:40:21: method has no receiver
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:40:21: syntax error: unexpected *, expecting name or (
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:46:16: method has no receiver
/tmp/arrow-HEAD.5MzaX/go/gopath/pkg/mod/github.com/apache/thrift@v0.17.0/lib/go/thrift/pool.go:46:16: too many errors
note: module requires Go 1.18
github.com/golang/snappy
github.com/klauspost/compress/flate
github.com/klauspost/compress/gzip
github.com/JohnCGriffin/overflow
github.com/apache/arrow/go/v14/parquet/internal/bmi
golang.org/x/exp/mmap
github.com/docopt/docopt-go
golang.org/x/sync/errgroup
github.com/davecgh/go-spew/spew
github.com/pmezard/go-difflib/difflib
github.com/stretchr/objx
gopkg.in/yaml.v3
github.com/stretchr/testify/assert
github.com/stretchr/testify/mock
Failed to verify release candidate. See /tmp/arrow-HEAD.5MzaX for details.

Component(s)

Continuous Integration, Go
@raulcd
Copy link
Member Author

raulcd commented Sep 15, 2023

cc @zeroshade

@raulcd
Copy link
Member Author

raulcd commented Sep 15, 2023

This seems to fail since we bumped the minimum go version: 2a56d45

@raulcd
Copy link
Member Author

raulcd commented Sep 15, 2023

@zeroshade if it's not a quick fix for you I can try to investigate next week.

@zeroshade
Copy link
Member

@raulcd ugh, it looks like it's still installing Go 1.17 instead of 1.19, I'll see if i can fix the verification scripts to get the right version

zeroshade added a commit to zeroshade/arrow that referenced this issue Sep 15, 2023
@zeroshade
apacheGH-37738: [Go][CI] Update Go version for verification
a6b489a
@github-actions github-actions bot mentioned this issue Sep 15, 2023
Merged
kou pushed a commit that referenced this issue Sep 15, 2023
@zeroshade
GH-37738: [Go][CI] Update Go version for verification (#37745)
1db4c99 
### Rationale for this change
Forgot to update the verification script to use the newer version of Go, it was still using Go 1.17

* Closes: #37738

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Sep 15, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@zeroshade @loicalleyne
apacheGH-37738: [Go][CI] Update Go version for verification (apache#3…
d5c3d4b 
…7745)

### Rationale for this change
Forgot to update the verification script to use the newer version of Go, it was still using Go 1.17

* Closes: apache#37738

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@zeroshade @dgreiss
apacheGH-37738: [Go][CI] Update Go version for verification (apache#3…
f57a70e 
…7745)

### Rationale for this change
Forgot to update the verification script to use the newer version of Go, it was still using Go 1.17

* Closes: apache#37738

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Continuous Integration Component: Go Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37738: [Go][CI] Update Go version for verification zeroshade/arrow
3 participants
@kou @zeroshade @raulcd