Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] cpp/src/**/*.cmake aren't cmake-format targets #37849

Closed
kou opened this issue Sep 25, 2023 · 0 comments · Fixed by #37850
Closed

[C++] cpp/src/**/*.cmake aren't cmake-format targets #37849

kou opened this issue Sep 25, 2023 · 0 comments · Fixed by #37850

Comments

@kou
Copy link
Member

kou commented Sep 25, 2023

Describe the enhancement requested

Our configuration misses them:

include_patterns=[
'ci/**/*.cmake',
'cpp/CMakeLists.txt',
'cpp/src/**/*.cmake.in',
'cpp/src/**/CMakeLists.txt',
'cpp/examples/**/CMakeLists.txt',
'cpp/cmake_modules/*.cmake',
'go/**/CMakeLists.txt',
'java/**/CMakeLists.txt',
'matlab/**/CMakeLists.txt',
'python/CMakeLists.txt',
],
exclude_patterns=[
'cpp/cmake_modules/FindNumPy.cmake',
'cpp/cmake_modules/FindPythonLibsNew.cmake',
'cpp/cmake_modules/UseCython.cmake',
'cpp/src/arrow/util/config.h.cmake',
]

Component(s)

C++

kou added a commit that referenced this issue Sep 25, 2023
### Rationale for this change

In general, all our `.cmake` files should be `cmake-format` targets.

### What changes are included in this PR?

Add missing patterns for `cpp/src/**/*.cmake`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #37849

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Sep 25, 2023
etseidl pushed a commit to etseidl/arrow that referenced this issue Sep 28, 2023
…pache#37850)

### Rationale for this change

In general, all our `.cmake` files should be `cmake-format` targets.

### What changes are included in this PR?

Add missing patterns for `cpp/src/**/*.cmake`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37849

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
…pache#37850)

### Rationale for this change

In general, all our `.cmake` files should be `cmake-format` targets.

### What changes are included in this PR?

Add missing patterns for `cpp/src/**/*.cmake`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37849

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…pache#37850)

### Rationale for this change

In general, all our `.cmake` files should be `cmake-format` targets.

### What changes are included in this PR?

Add missing patterns for `cpp/src/**/*.cmake`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37849

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…pache#37850)

### Rationale for this change

In general, all our `.cmake` files should be `cmake-format` targets.

### What changes are included in this PR?

Add missing patterns for `cpp/src/**/*.cmake`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37849

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant