Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Memory leak in TestFlightSqlStreams Test class #38268

Closed
danepitkin opened this issue Oct 14, 2023 · 2 comments · Fixed by #38319
Closed

[Java] Memory leak in TestFlightSqlStreams Test class #38268

danepitkin opened this issue Oct 14, 2023 · 2 comments · Fixed by #38319
Assignees
@jduo
Labels
Component: Java Type: bug
Milestone
15.0.0

Comments

@danepitkin
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

We are seeing flaky error reports of TestFlightSqlStreams leaking memory on tearDown.

Examles:
https://github.com/apache/arrow/actions/runs/6509901078/job/17682438616?pr=37896#step:7:12487
https://github.com/apache/arrow/actions/runs/6518489922/job/17703968625?pr=38219

Component(s)

Java
@jduo
Copy link
Member

jduo commented Oct 17, 2023

This failure looks to be similar to other tests that start a FlightServer and get streams of data back:
#6392

It is likely that the FlightServer isn't shutting down quickly enough during close(), where it will only try for 6 seconds. If the timeout is exceeded the server will log a warning saying "Couldn't shutdown server, resources likely to be leaked".

For now this test will be @disabled, and we can come back to this to fix the race condition.

@jduo jduo mentioned this issue Oct 17, 2023
Closed
@jduo
Copy link
Member

jduo commented Oct 17, 2023

I've put up a new issue to track re-investigating this problem: #38318

jduo added a commit to jduo/arrow that referenced this issue Oct 17, 2023
@jduo
apacheGH-38268: [Java] Disable flaky TestFlightSqlStreams
480f299 
Disable the TestFlightSqlStreams test case, which is
currently flaky and sporadically fails with a
memory leak.
@github-actions github-actions bot mentioned this issue Oct 17, 2023
Merged
lidavidm pushed a commit that referenced this issue Oct 20, 2023
@jduo
GH-38268: [Java] Disable flaky TestFlightSqlStreams (#38319)
cda7ffc 
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: #38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 15.0.0 milestone Oct 20, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@jduo
apacheGH-38268: [Java] Disable flaky TestFlightSqlStreams (apache#38319)
e132be7 
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: apache#38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 25, 2023
@jduo @JerAguilon
apacheGH-38268: [Java] Disable flaky TestFlightSqlStreams (apache#38319)
8a58baf 
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: apache#38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@jduo @loicalleyne
apacheGH-38268: [Java] Disable flaky TestFlightSqlStreams (apache#38319)
742f28d 
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: apache#38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jduo @dgreiss
apacheGH-38268: [Java] Disable flaky TestFlightSqlStreams (apache#38319)
9d185a5 
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: apache#38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jduo jduo

Labels
Component: Java Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38268: [Java] Disable flaky TestFlightSqlStreams jduo/arrow
3 participants
@lidavidm @jduo @danepitkin