Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38268: [Java] Disable flaky TestFlightSqlStreams #38319

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

jduo
Copy link
Member

@jduo jduo commented Oct 17, 2023

Rationale for this change

The TestFlightSqlStreams test is failing sporadically in CI.

What changes are included in this PR?

Disables the tests for now.

Are these changes tested?

N/A

Are there any user-facing changes?

No.

Disable the TestFlightSqlStreams test case, which is
currently flaky and sporadically fails with a
memory leak.
@jduo jduo requested a review from lidavidm as a code owner October 17, 2023 19:22
@jduo
Copy link
Member Author

jduo commented Oct 17, 2023

@danepitkin

@github-actions
Copy link

⚠️ GitHub issue #38268 has been automatically assigned in GitHub to PR creator.

@danepitkin
Copy link
Member

LGTM! Thank you!

@lidavidm lidavidm merged commit cda7ffc into apache:main Oct 20, 2023
13 of 14 checks passed
@lidavidm lidavidm removed the awaiting review Awaiting review label Oct 20, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit cda7ffc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: apache#38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@jduo jduo deleted the 38268-flight-test-memory-leak branch October 23, 2023 15:24
JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 25, 2023
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: apache#38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: apache#38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change
The TestFlightSqlStreams test is failing sporadically in CI.

### What changes are included in this PR?
Disables the tests for now.

### Are these changes tested?
N/A

### Are there any user-facing changes?
No.

* Closes: apache#38268

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Memory leak in TestFlightSqlStreams Test class
3 participants