Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Use new encrypted files for page index encryption test #38346

Closed
wgtmac opened this issue Oct 19, 2023 · 0 comments · Fixed by #38347
Closed

[C++][Parquet] Use new encrypted files for page index encryption test #38346

wgtmac opened this issue Oct 19, 2023 · 0 comments · Fixed by #38347
Assignees
@wgtmac
Labels
Component: C++ Component: Parquet Type: enhancement
Milestone
15.0.0

Comments

@wgtmac
Copy link
Member

wgtmac commented Oct 19, 2023

Describe the enhancement requested

Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index.

Component(s)

C++, Parquet
wgtmac added a commit to wgtmac/arrow that referenced this issue Oct 19, 2023
@wgtmac
apacheGH-38346: Use new encrypted files for page index encryption test
df9ee29
@github-actions github-actions bot mentioned this issue Oct 19, 2023
Merged
mapleFU pushed a commit that referenced this issue Oct 25, 2023
@wgtmac
GH-38346: [C++][Parquet] Use new encrypted files for page index encry…
e836061 
…ption test (#38347)

### Rationale for this change

Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index.

### What changes are included in this PR?

Minor refactor read_configurations_test.cc to check page index from all parquet files.

### Are these changes tested?

This is indeed a unit test enhancement.

### Are there any user-facing changes?

NO.
* Closes: #38346

Authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
@mapleFU mapleFU added this to the 15.0.0 milestone Oct 25, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 25, 2023
@wgtmac @JerAguilon
apacheGH-38346: [C++][Parquet] Use new encrypted files for page index…
27697de 
… encryption test (apache#38347)

### Rationale for this change

Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index.

### What changes are included in this PR?

Minor refactor read_configurations_test.cc to check page index from all parquet files.

### Are these changes tested?

This is indeed a unit test enhancement.

### Are there any user-facing changes?

NO.
* Closes: apache#38346

Authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@wgtmac @loicalleyne
apacheGH-38346: [C++][Parquet] Use new encrypted files for page index…
5379e6e 
… encryption test (apache#38347)

### Rationale for this change

Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index.

### What changes are included in this PR?

Minor refactor read_configurations_test.cc to check page index from all parquet files.

### Are these changes tested?

This is indeed a unit test enhancement.

### Are there any user-facing changes?

NO.
* Closes: apache#38346

Authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@wgtmac @dgreiss
apacheGH-38346: [C++][Parquet] Use new encrypted files for page index…
8ea3ce4 
… encryption test (apache#38347)

### Rationale for this change

Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index.

### What changes are included in this PR?

Minor refactor read_configurations_test.cc to check page index from all parquet files.

### Are these changes tested?

This is indeed a unit test enhancement.

### Are there any user-facing changes?

NO.
* Closes: apache#38346

Authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wgtmac wgtmac

Labels
Component: C++ Component: Parquet Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38346: [C++][Parquet] Use new encrypted files for page index encryption test wgtmac/arrow
2 participants
@wgtmac @mapleFU