-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][Memory] Murmur hash implementation failing to hash less than 4 bytes. #38366
Comments
manolama
added a commit
to manolama/arrow
that referenced
this issue
Oct 19, 2023
manolama
added a commit
to manolama/arrow
that referenced
this issue
Oct 19, 2023
manolama
added a commit
to manolama/arrow
that referenced
this issue
Oct 19, 2023
lidavidm
pushed a commit
that referenced
this issue
Oct 20, 2023
### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: #38366 Authored-by: Chris Larsen <clarsen@netflix.com> Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 23, 2023
…pache#38368) ### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: apache#38366 Authored-by: Chris Larsen <clarsen@netflix.com> Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 25, 2023
…pache#38368) ### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: apache#38366 Authored-by: Chris Larsen <clarsen@netflix.com> Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…pache#38368) ### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: apache#38366 Authored-by: Chris Larsen <clarsen@netflix.com> Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…pache#38368) ### Rationale for this change Using the `MurmurHash` implementation would cause collisions on small input values. ### What changes are included in this PR? Fix the iteration for small and tail values that are not 4 bytes in length. ### Are these changes tested? Yes ### Are there any user-facing changes? Unlikely unless someone was using the `MurmurHash` functions to persist a hash value. * Closes: apache#38366 Authored-by: Chris Larsen <clarsen@netflix.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
When attempting to use the
MurmurHasher
for values likefoo
andbar
, the same hash was produced.Reproduction:
produces
Component(s)
Java
The text was updated successfully, but these errors were encountered: