-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Connection is garbage-collected, use dbDisconnect() to avoid this (when using to_duckdb()) #38382
Comments
thisisnic
pushed a commit
that referenced
this issue
Nov 1, 2023
…38495) ### Rationale for this change We get lots of warning messages about unclosed connections when running tests + users get them on exit when they weren't expecting them. ### What changes are included in this PR? A finalizer was added on exit to close the global arrow_duck_con that we cache in the global options. ### Are these changes tested? Yes, the finalizer will run in every test that runs `to_duckb()` with the default connection. ### Are there any user-facing changes? No. * Closes: #38382 Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…exit (apache#38495) ### Rationale for this change We get lots of warning messages about unclosed connections when running tests + users get them on exit when they weren't expecting them. ### What changes are included in this PR? A finalizer was added on exit to close the global arrow_duck_con that we cache in the global options. ### Are these changes tested? Yes, the finalizer will run in every test that runs `to_duckb()` with the default connection. ### Are there any user-facing changes? No. * Closes: apache#38382 Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Nic Crane <thisisnic@gmail.com>
assignUser
pushed a commit
that referenced
this issue
Jan 10, 2024
…38495) ### Rationale for this change We get lots of warning messages about unclosed connections when running tests + users get them on exit when they weren't expecting them. ### What changes are included in this PR? A finalizer was added on exit to close the global arrow_duck_con that we cache in the global options. ### Are these changes tested? Yes, the finalizer will run in every test that runs `to_duckb()` with the default connection. ### Are there any user-facing changes? No. * Closes: #38382 Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…exit (apache#38495) ### Rationale for this change We get lots of warning messages about unclosed connections when running tests + users get them on exit when they weren't expecting them. ### What changes are included in this PR? A finalizer was added on exit to close the global arrow_duck_con that we cache in the global options. ### Are these changes tested? Yes, the finalizer will run in every test that runs `to_duckb()` with the default connection. ### Are there any user-facing changes? No. * Closes: apache#38382 Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have the following code:
When I quit R I get this message:
One way to avoid this is to explicitly use a connection:
Credit: https://discord.com/channels/909674491309850675/921100826884341781/1165053445657608222
Is this expected or it should be done automatically?
Created on 2023-10-21 with reprex v2.0.2
Session info
The text was updated successfully, but these errors were encountered: