GH-38382: [R] Explicitly clean up arrow_duck_connection() on exit
#38495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
|
@amoeba Can you give this a quick review? All the R CI jobs are currently failing due to a dbplyr update and this PR contains a fix! |
|
Hey @paleolimbot, this looks good to me. Thanks for taking care if both things. |
thisisnic
approved these changes
Nov 1, 2023
|
@github-actions crossbow submit -g r |
github-actions
bot
added
awaiting merge
|
Revision: 9b9186a Submitted crossbow builds: ursacomputing/crossbow @ actions-0487ce50cd
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 57c028f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…exit (apache#38495) ### Rationale for this change We get lots of warning messages about unclosed connections when running tests + users get them on exit when they weren't expecting them. ### What changes are included in this PR? A finalizer was added on exit to close the global arrow_duck_con that we cache in the global options. ### Are these changes tested? Yes, the finalizer will run in every test that runs `to_duckb()` with the default connection. ### Are there any user-facing changes? No. * Closes: apache#38382 Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Nic Crane <thisisnic@gmail.com>
assignUser
pushed a commit
that referenced
this pull request
Jan 10, 2024
…38495) ### Rationale for this change We get lots of warning messages about unclosed connections when running tests + users get them on exit when they weren't expecting them. ### What changes are included in this PR? A finalizer was added on exit to close the global arrow_duck_con that we cache in the global options. ### Are these changes tested? Yes, the finalizer will run in every test that runs `to_duckb()` with the default connection. ### Are there any user-facing changes? No. * Closes: #38382 Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…exit (apache#38495) ### Rationale for this change We get lots of warning messages about unclosed connections when running tests + users get them on exit when they weren't expecting them. ### What changes are included in this PR? A finalizer was added on exit to close the global arrow_duck_con that we cache in the global options. ### Are these changes tested? Yes, the finalizer will run in every test that runs `to_duckb()` with the default connection. ### Are there any user-facing changes? No. * Closes: apache#38382 Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We get lots of warning messages about unclosed connections when running tests + users get them on exit when they weren't expecting them.
What changes are included in this PR?
A finalizer was added on exit to close the global arrow_duck_con that we cache in the global options.
Are these changes tested?
Yes, the finalizer will run in every test that runs
to_duckb()with the default connection.Are there any user-facing changes?
No.