Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][C++] test-debian-11-cpp-i386 failed by long long int to size_t conversion #38556

Closed
kou opened this issue Nov 2, 2023 · 0 comments · Fixed by #38557
Closed

[CI][C++] test-debian-11-cpp-i386 failed by long long int to size_t conversion #38556

kou opened this issue Nov 2, 2023 · 0 comments · Fixed by #38557
Assignees
Milestone

Comments

@kou
Copy link
Member

kou commented Nov 2, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Since 2023-10-27 nightly. GH-37792 may be related.

https://github.com/ursacomputing/crossbow/actions/runs/6661264414/job/18103856370#step:6:1230

FAILED: src/arrow/CMakeFiles/arrow_objlib.dir/array/data.cc.o 
/usr/local/bin/sccache /usr/lib/ccache/g++ -DARROW_EXPORTING -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_HDFS -DARROW_MIMALLOC -DARROW_WITH_BACKTRACE -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_RE2 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_NO_LIB -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DURI_STATIC_BUILD -Isrc -I/arrow/cpp/src -I/arrow/cpp/src/generated -isystem /arrow/cpp/thirdparty/flatbuffers/include -isystem /arrow/cpp/thirdparty/hadoop/include -isystem google_cloud_cpp_ep-install/include -isystem absl_ep-install/include -isystem crc32c_ep-install/include -isystem orc_ep-install/include -isystem xsimd_ep/src/xsimd_ep-install/include -isystem jemalloc_ep-prefix/src -isystem mimalloc_ep/src/mimalloc_ep/include/mimalloc-2.0 -Wno-noexcept-type  -fdiagnostics-color=always  -Wall -Wno-conversion -Wno-sign-conversion -Wunused-result -Wdate-time -fno-semantic-interposition -msse4.2  -g -Werror -O0 -ggdb -g1 -fPIC -pthread -std=c++17 -MD -MT src/arrow/CMakeFiles/arrow_objlib.dir/array/data.cc.o -MF src/arrow/CMakeFiles/arrow_objlib.dir/array/data.cc.o.d -o src/arrow/CMakeFiles/arrow_objlib.dir/array/data.cc.o -c /arrow/cpp/src/arrow/array/data.cc
/arrow/cpp/src/arrow/array/data.cc: In member function 'arrow::util::span<const std::shared_ptr<arrow::Buffer> > arrow::ArraySpan::GetVariadicBuffers() const':
/arrow/cpp/src/arrow/array/data.cc:571:27: error: narrowing conversion of '(((long long int)((const arrow::ArraySpan*)this)->arrow::ArraySpan::buffers[2].arrow::BufferSpan::size) / ((long long int)sizeof (std::shared_ptr<arrow::Buffer>)))' from 'long long int' to 'size_t' {aka 'unsigned int'} [-Werror=narrowing]
  571 |           buffers[2].size / sizeof(std::shared_ptr<Buffer>)};
      |           ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

Component(s)

C++

@kou kou added the Type: bug label Nov 2, 2023
kou added a commit to kou/arrow that referenced this issue Nov 2, 2023
kou added a commit to kou/arrow that referenced this issue Nov 2, 2023
@kou kou closed this as completed in #38557 Nov 6, 2023
kou added a commit that referenced this issue Nov 6, 2023
### Rationale for this change

We need explicit cast for `int64_t` to `size_t` conversion for i386 environment.

This was introduced by GH-37792.

### What changes are included in this PR?

Add explicit cast.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38556

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Nov 6, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Nov 9, 2023
…he#38557)

### Rationale for this change

We need explicit cast for `int64_t` to `size_t` conversion for i386 environment.

This was introduced by apacheGH-37792.

### What changes are included in this PR?

Add explicit cast.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38556

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…he#38557)

### Rationale for this change

We need explicit cast for `int64_t` to `size_t` conversion for i386 environment.

This was introduced by apacheGH-37792.

### What changes are included in this PR?

Add explicit cast.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38556

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…he#38557)

### Rationale for this change

We need explicit cast for `int64_t` to `size_t` conversion for i386 environment.

This was introduced by apacheGH-37792.

### What changes are included in this PR?

Add explicit cast.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38556

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant