Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Remove bashism from configure script #38715

Closed
paleolimbot opened this issue Nov 14, 2023 · 0 comments · Fixed by #38716
Closed

[R] Remove bashism from configure script #38715

paleolimbot opened this issue Nov 14, 2023 · 0 comments · Fixed by #38716
Assignees
@paleolimbot
Labels
Component: R Type: bug
Milestone
14.0.2

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

The incoming pretest fails with

* checking top-level files ... NOTE
  possible bashism in configure line 138 (test -a/-o):
  if [ "${OPENSSL_ROOT_DIR}" = "" -a "${PKG_CONFIG_AVAILABLE}" = "true" ]; then

...so we need to remove the test -a usage from the configure script.

Component(s)

R
@github-actions github-actions bot mentioned this issue Nov 14, 2023
Merged
paleolimbot added a commit that referenced this issue Nov 15, 2023
@paleolimbot
GH-38715: [R] Fix possible bashism in configure script (#38716)
a886fda 
### Rationale for this change

The CRAN incoming check for 14.0.0 is failing with a NOTE about a possible bashism

### What changes are included in this PR?

One `test -a` usage was replaced with `&&`.

### Are these changes tested?

Yes (via crossbow, below)

### Are there any user-facing changes?

No
* Closes: #38715

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@paleolimbot paleolimbot added this to the 15.0.0 milestone Nov 15, 2023
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Nov 15, 2023
@paleolimbot @thisisnic
apacheGH-38715: [R] Fix possible bashism in configure script (apache#…
c19ad3a 
…38716)

### Rationale for this change

The CRAN incoming check for 14.0.0 is failing with a NOTE about a possible bashism

### What changes are included in this PR?

One `test -a` usage was replaced with `&&`.

### Are these changes tested?

Yes (via crossbow, below)

### Are there any user-facing changes?

No
* Closes: apache#38715

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@assignUser assignUser modified the milestones: 15.0.0, 14.0.2 Nov 27, 2023
raulcd pushed a commit that referenced this issue Nov 28, 2023
@paleolimbot @raulcd
GH-38715: [R] Fix possible bashism in configure script (#38716)
1e05986 
### Rationale for this change

The CRAN incoming check for 14.0.0 is failing with a NOTE about a possible bashism

### What changes are included in this PR?

One `test -a` usage was replaced with `&&`.

### Are these changes tested?

Yes (via crossbow, below)

### Are there any user-facing changes?

No
* Closes: #38715

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@paleolimbot @dgreiss
apacheGH-38715: [R] Fix possible bashism in configure script (apache#…
b809544 
…38716)

### Rationale for this change

The CRAN incoming check for 14.0.0 is failing with a NOTE about a possible bashism

### What changes are included in this PR?

One `test -a` usage was replaced with `&&`.

### Are these changes tested?

Yes (via crossbow, below)

### Are there any user-facing changes?

No
* Closes: apache#38715

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: R Type: bug
Projects
None yet
Milestone
14.0.2
Development

Successfully merging a pull request may close this issue.

GH-38715: [R] Fix possible bashism in configure script paleolimbot/arrow
2 participants
@paleolimbot @assignUser