Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] cmake download doesn't work on macOS #38811

Closed
jonkeane opened this issue Nov 20, 2023 · 1 comment · Fixed by #39453
Closed

[R] cmake download doesn't work on macOS #38811

jonkeane opened this issue Nov 20, 2023 · 1 comment · Fixed by #39453
Assignees
@jonkeane
Labels
Component: R Type: bug
Milestone
15.0.0

Comments

@jonkeane
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

When downloading from https://github.com/Kitware/CMake/releases/download/v3.26.4/cmake-3.26.4-macos-universal.tar.gz in nixlibs.R, this will result in a CMake.app being located on the path, we need to add on to the path CMake.app/Contents/bin/ instead of just bin

Component(s)

R
@assignUser
Copy link
Member

I came across this as well #38777 but you have already pinpointed the issue so I am closing the other one :)

@assignUser assignUser mentioned this issue Nov 21, 2023
Closed
@jonkeane jonkeane self-assigned this Jan 4, 2024
@jonkeane jonkeane mentioned this issue Jan 4, 2024
Merged
assignUser pushed a commit that referenced this issue Jan 8, 2024
@jonkeane
GH-38811: [R] Actually use fetched cmake on macos (#39453)
20bcf0f 
### Rationale for this change

We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. 

### What changes are included in this PR?

Resolves #38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release.

### Are these changes tested?

Yes, in CI with the local (source) install jobs in crossbow)

### Are there any user-facing changes?

* Closes: #38811

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 15.0.0 milestone Jan 8, 2024
raulcd pushed a commit that referenced this issue Jan 9, 2024
@jonkeane @raulcd
GH-38811: [R] Actually use fetched cmake on macos (#39453)
394fd5a 
### Rationale for this change

We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. 

### What changes are included in this PR?

Resolves #38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release.

### Are these changes tested?

Yes, in CI with the local (source) install jobs in crossbow)

### Are there any user-facing changes?

* Closes: #38811

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
assignUser pushed a commit that referenced this issue Jan 9, 2024
@jonkeane @assignUser
GH-38811: [R] Actually use fetched cmake on macos (#39453)
c186538 
### Rationale for this change

We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. 

### What changes are included in this PR?

Resolves #38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release.

### Are these changes tested?

Yes, in CI with the local (source) install jobs in crossbow)

### Are there any user-facing changes?

* Closes: #38811

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@jonkeane @clayburn
apacheGH-38811: [R] Actually use fetched cmake on macos (apache#39453)
285ade3 
### Rationale for this change

We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. 

### What changes are included in this PR?

Resolves apache#38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release.

### Are these changes tested?

Yes, in CI with the local (source) install jobs in crossbow)

### Are there any user-facing changes?

* Closes: apache#38811

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jonkeane @dgreiss
apacheGH-38811: [R] Actually use fetched cmake on macos (apache#39453)
92d5d3c 
### Rationale for this change

We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. 

### What changes are included in this PR?

Resolves apache#38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release.

### Are these changes tested?

Yes, in CI with the local (source) install jobs in crossbow)

### Are there any user-facing changes?

* Closes: apache#38811

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@jonkeane @zanmato1984
apacheGH-38811: [R] Actually use fetched cmake on macos (apache#39453)
33c7c1c 
### Rationale for this change

We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. 

### What changes are included in this PR?

Resolves apache#38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release.

### Are these changes tested?

Yes, in CI with the local (source) install jobs in crossbow)

### Are there any user-facing changes?

* Closes: apache#38811

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonkeane jonkeane

Labels
Component: R Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38811: [R] Actually use fetched cmake on macos jonkeane/arrow
2 participants
@jonkeane @assignUser