-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] cmake download doesn't work on macOS #38811
Comments
I came across this as well #38777 but you have already pinpointed the issue so I am closing the other one :) |
assignUser
pushed a commit
that referenced
this issue
Jan 8, 2024
### Rationale for this change We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. ### What changes are included in this PR? Resolves #38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release. ### Are these changes tested? Yes, in CI with the local (source) install jobs in crossbow) ### Are there any user-facing changes? * Closes: #38811 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
raulcd
pushed a commit
that referenced
this issue
Jan 9, 2024
### Rationale for this change We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. ### What changes are included in this PR? Resolves #38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release. ### Are these changes tested? Yes, in CI with the local (source) install jobs in crossbow) ### Are there any user-facing changes? * Closes: #38811 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
assignUser
pushed a commit
that referenced
this issue
Jan 9, 2024
### Rationale for this change We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. ### What changes are included in this PR? Resolves #38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release. ### Are these changes tested? Yes, in CI with the local (source) install jobs in crossbow) ### Are there any user-facing changes? * Closes: #38811 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this issue
Jan 23, 2024
### Rationale for this change We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. ### What changes are included in this PR? Resolves apache#38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release. ### Are these changes tested? Yes, in CI with the local (source) install jobs in crossbow) ### Are there any user-facing changes? * Closes: apache#38811 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
### Rationale for this change We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. ### What changes are included in this PR? Resolves apache#38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release. ### Are these changes tested? Yes, in CI with the local (source) install jobs in crossbow) ### Are there any user-facing changes? * Closes: apache#38811 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
### Rationale for this change We sometimes need to use a more modern cmake, before this change although we downloaded a functioning cmake on macos, we didn't have the correct path for it. ### What changes are included in this PR? Resolves apache#38811 so that cmake is useable when downloaded on macos. This also restores the local source build jobs to be testing that source builds work (which is what the Ci jobs say they are doing). I believe these jobs started using binaries when we overhauled the build system last release. ### Are these changes tested? Yes, in CI with the local (source) install jobs in crossbow) ### Are there any user-facing changes? * Closes: apache#38811 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
When downloading from https://github.com/Kitware/CMake/releases/download/v3.26.4/cmake-3.26.4-macos-universal.tar.gz in nixlibs.R, this will result in a
CMake.app
being located on the path, we need to add on to the pathCMake.app/Contents/bin/
instead of justbin
Component(s)
R
The text was updated successfully, but these errors were encountered: