Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Expose append parameter from FileOutputStream::Open #38857

Closed
milesgranger opened this issue Nov 23, 2023 · 0 comments · Fixed by #38820 or #39027
Closed

[Python] Expose append parameter from FileOutputStream::Open #38857

milesgranger opened this issue Nov 23, 2023 · 0 comments · Fixed by #38820 or #39027
Assignees
@milesgranger
Labels
Component: Python Type: enhancement
Milestone
15.0.0

Comments

@milesgranger
Copy link
Contributor

Describe the enhancement requested

Allow PyArrow's OsFile to set the append parameter from FileOutputStream::Open.

Component(s)

Python
@github-actions github-actions bot mentioned this issue Nov 23, 2023
Merged
AlenkaF pushed a commit that referenced this issue Nov 30, 2023
@milesgranger
GH-38857: [Python] Add append mode for pyarrow.OsFile (#38820)
92fe831 
### Rationale for this change

Seems reasonable. :) 

### What changes are included in this PR?

Exposes the C++ append parameter from FileOutputStream  to PyArrow's OSFile.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Can add `a` or `ab` to `mode` parameter in `pyarrow.OsFile`

* Closes: #38857

Authored-by: Miles Granger <miles59923@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
jorisvandenbossche added a commit to jorisvandenbossche/arrow that referenced this issue Dec 1, 2023
@jorisvandenbossche
apacheGH-38857: [Python] Fix append mode for cython 2
38e8a4e
@github-actions github-actions bot mentioned this issue Dec 1, 2023
Merged
jorisvandenbossche added a commit that referenced this issue Dec 1, 2023
@jorisvandenbossche
GH-38857: [Python] Fix append mode for cython 2 (#39027)
2bd8e06 
### Rationale for this change

Small fixup of the change in #38820 to fix the build failure on cython 2 (nightly crossbow build)
* Closes: #38857

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@AlenkaF AlenkaF added this to the 15.0.0 milestone Dec 2, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@milesgranger @dgreiss
apacheGH-38857: [Python] Add append mode for pyarrow.OsFile (apache#3…
fcc2dff 
…8820)

### Rationale for this change

Seems reasonable. :) 

### What changes are included in this PR?

Exposes the C++ append parameter from FileOutputStream  to PyArrow's OSFile.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Can add `a` or `ab` to `mode` parameter in `pyarrow.OsFile`

* Closes: apache#38857

Authored-by: Miles Granger <miles59923@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jorisvandenbossche @dgreiss
apacheGH-38857: [Python] Fix append mode for cython 2 (apache#39027)
1095b46 
### Rationale for this change

Small fixup of the change in apache#38820 to fix the build failure on cython 2 (nightly crossbow build)
* Closes: apache#38857

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milesgranger milesgranger

Labels
Component: Python Type: enhancement
Projects
None yet
Milestone
15.0.0
2 participants
@milesgranger @AlenkaF