Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38857: [Python] Fix append mode for cython 2 #39027

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Dec 1, 2023

Rationale for this change

Small fixup of the change in #38820 to fix the build failure on cython 2 (nightly crossbow build)

@jorisvandenbossche
Copy link
Member Author

The question is also whether we actually need to keep this cython 2 compatibility around for longer. I think we can probably also just start requiring cython >= 3 for building pyarrow.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.10-cython2

Copy link

github-actions bot commented Dec 1, 2023

Revision: 38e8a4e

Submitted crossbow builds: ursacomputing/crossbow @ actions-7f496d3260

Task Status
test-conda-python-3.10-cython2 Github Actions

@jorisvandenbossche jorisvandenbossche merged commit 2bd8e06 into apache:main Dec 1, 2023
11 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Dec 1, 2023
@jorisvandenbossche jorisvandenbossche deleted the gh-38820-fixup branch December 1, 2023 13:48
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2bd8e06.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

Small fixup of the change in apache#38820 to fix the build failure on cython 2 (nightly crossbow build)
* Closes: apache#38857

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Expose append parameter from FileOutputStream::Open
1 participant