You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/// \brief Interface for comparison of physical types according to the/// semantics of a particular logical type.template <typename DType>
classTypedComparator : publicComparator {
public:using T = typename DType::c_type;
/// \brief Scalar comparison of two elements, return true if first/// is strictly less than the secondvirtualboolCompare(const T& a, const T& b) = 0;
/// \brief Compute maximum and minimum elements in a batch of/// elements without any nullsvirtual std::pair<T, T> GetMinMax(const T* values, int64_t length) = 0;
/// \brief Compute minimum and maximum elements from an Arrow array. Only/// valid for certain Parquet Type / Arrow Type combinations, like BYTE_ARRAY/// / arrow::BinaryArrayvirtual std::pair<T, T> GetMinMax(const ::arrow::Array& values) = 0;
/// \brief Compute maximum and minimum elements in a batch of/// elements with accompanying bitmap indicating which elements are/// included (bit set) and excluded (bit not set)////// \param[in] values the sequence of values/// \param[in] length the length of the sequence/// \param[in] valid_bits a bitmap indicating which elements are/// included (1) or excluded (0)/// \param[in] valid_bits_offset the bit offset into the bitmap of/// the first element in the sequencevirtual std::pair<T, T> GetMinMaxSpaced(const T* values, int64_t length,
constuint8_t* valid_bits,
int64_t valid_bits_offset) = 0;
};
Current they're all non-const functions. So we need to making them as const.
Component(s)
C++, Parquet
The text was updated successfully, but these errors were encountered:
…ion as const method (#38875)
### Rationale for this change
`parquet::TypedComparator<DType>` is not const method, which should be const
### What changes are included in this PR?
Change `Compare`, `GetMinMax`, `GetMinMaxSpaced` to const
### Are these changes tested?
No
### Are there any user-facing changes?
No
* Closes: #38874
Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
…operation as const method (apache#38875)
### Rationale for this change
`parquet::TypedComparator<DType>` is not const method, which should be const
### What changes are included in this PR?
Change `Compare`, `GetMinMax`, `GetMinMaxSpaced` to const
### Are these changes tested?
No
### Are there any user-facing changes?
No
* Closes: apache#38874
Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
Describe the enhancement requested
Current they're all non-const functions. So we need to making them as const.
Component(s)
C++, Parquet
The text was updated successfully, but these errors were encountered: