-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38874: [C++][Parquet] Minor: making parquet TypedComparator operation as const method #38875
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Will merge it tonight if no further comments |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c614014. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…operation as const method (apache#38875) ### Rationale for this change `parquet::TypedComparator<DType>` is not const method, which should be const ### What changes are included in this PR? Change `Compare`, `GetMinMax`, `GetMinMaxSpaced` to const ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#38874 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
Rationale for this change
parquet::TypedComparator<DType>
is not const method, which should be constWhat changes are included in this PR?
Change
Compare
,GetMinMax
,GetMinMaxSpaced
to constAre these changes tested?
No
Are there any user-facing changes?
No