Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38874: [C++][Parquet] Minor: making parquet TypedComparator operation as const method #38875

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Nov 24, 2023

Rationale for this change

parquet::TypedComparator<DType> is not const method, which should be const

What changes are included in this PR?

Change Compare, GetMinMax, GetMinMaxSpaced to const

Are these changes tested?

No

Are there any user-facing changes?

No

@mapleFU mapleFU requested a review from wgtmac as a code owner November 24, 2023 13:10
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@mapleFU mapleFU changed the title [C++][Parquet] Minor: making parquet TypedComparator operation as const method GH-38874: [C++][Parquet] Minor: making parquet TypedComparator operation as const method Nov 24, 2023
Copy link

⚠️ GitHub issue #38874 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 24, 2023
@mapleFU mapleFU requested a review from pitrou November 24, 2023 19:42
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Nov 27, 2023
@mapleFU
Copy link
Member Author

mapleFU commented Nov 28, 2023

Will merge it tonight if no further comments

@mapleFU mapleFU merged commit c614014 into apache:main Nov 28, 2023
34 checks passed
@mapleFU mapleFU removed the awaiting merge Awaiting merge label Nov 28, 2023
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c614014.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@mapleFU mapleFU deleted the making-stats-filter-const branch November 29, 2023 05:08
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…operation as const method (apache#38875)

### Rationale for this change

`parquet::TypedComparator<DType>` is not const method, which should be const

### What changes are included in this PR?

Change `Compare`, `GetMinMax`, `GetMinMaxSpaced` to const

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#38874

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][Parquet] Minor: making parquet TypedComparator operation as const method
3 participants