Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Improve error message when Flight Core TestTls fails #39170

Closed
jbonofre opened this issue Dec 11, 2023 · 1 comment · Fixed by #39171
Closed

[Java] Improve error message when Flight Core TestTls fails #39170

jbonofre opened this issue Dec 11, 2023 · 1 comment · Fixed by #39171

Comments

@jbonofre
Copy link
Member

Describe the enhancement requested

As discussed on the mailing list, when we forgot git submodule update --init --recursive, cert0.pem and other files are not present in testing/data folder.
It means TestTls fails, but it's not obvious to find why related to https://arrow.apache.org/docs/dev/developers/java/building.html#building.

I propose to display a "dev friendly" message ;)

Component(s)

Java

@jbonofre jbonofre changed the title Improve error message when Flight Core TestTls fails [Java] Improve error message when Flight Core TestTls fails Dec 11, 2023
@raulcd
Copy link
Member

raulcd commented Dec 11, 2023

Just as a note, this seems to be the same issue I am facing on some of the verification tasks on the 14.0.2 RC2 PR: #39155
I've commented on Zulip but I can see some failures like:

 E           RuntimeError: Test resource /var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/arrow-14.0.2.XXXXX.6zoUTjWt/apache-arrow-14.0.2/testing/data/flight/root-ca.pem not found; did you initialize the test resource submodule?
E           Traceback (most recent call last):
E             File "/private/var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/arrow-14.0.2.XXXXX.6zoUTjWt/venv-wheel-3.10-macosx_10_14_x86_64/lib/python3.10/site-packages/pyarrow/tests/test_flight.py", line 78, in read_flight_resource
E               with (root / path).open("rb") as f:
E             File "/usr/local/Cellar/python@3.10/3.10.13/Frameworks/Python.framework/Versions/3.10/lib/python3.10/pathlib.py", line 1119, in open
E               return self._accessor.open(self, mode, buffering, encoding, errors,
E           FileNotFoundError: [Errno 2] No such file or directory: '/var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/arrow-14.0.2.XXXXX.6zoUTjWt/apache-arrow-14.0.2/testing/data/flight/root-ca.pem'

or:

E1209 11:27:03.689191000 4697794048 ssl_security_connector.cc:273]     Handshaker factory creation failed with TSI_INVALID_ARGUMENT.
E1209 11:27:03.689258000 4697794048 chttp2_server.cc:1053]             UNKNOWN:Unable to create secure server with credentials of type Ssl {created_time:"2023-12-09T11:27:03.689234+00:00"}
/var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/arrow-14.0.2.XXXXX.zxdYorT4/apache-arrow-14.0.2/cpp/src/arrow/flight/flight_test.cc:465: Failure
Failed
'ExampleTlsCertificates(&options.tls_certificates)' failed with IOError: Could not open certificate: /var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/arrow-14.0.2.XXXXX.zxdYorT4/apache-arrow-14.0.2/testing/data/flight/cert0.pem
[  FAILED  ] TestTls.DoAction (2 ms)

I might revert the following commit: bc1ea6f on the RC2 branch to see if those failures for the Release are solved.

jbonofre added a commit to jbonofre/arrow that referenced this issue Dec 11, 2023
lidavidm pushed a commit that referenced this issue Dec 11, 2023
…ail (#39171)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #39170

Authored-by: JB Onofré <jbonofre@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 15.0.0 milestone Dec 11, 2023
mapleFU pushed a commit to mapleFU/arrow that referenced this issue Dec 13, 2023
…ight fail (apache#39171)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#39170

Authored-by: JB Onofré <jbonofre@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
…ight fail (apache#39171)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#39170

Authored-by: JB Onofré <jbonofre@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…ight fail (apache#39171)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#39170

Authored-by: JB Onofré <jbonofre@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants