-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39170: [Java] Improve error message explaining why TestTls might fail #39171
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
This closes #39170 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
java/flight/flight-core/src/test/java/org/apache/arrow/flight/FlightTestUtil.java
Outdated
Show resolved
Hide resolved
@lidavidm I updated the PR according to your suggestion. Thanks again. This PR is the first one of several coming from me 😄 |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 7ba0228. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ight fail (apache#39171) ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39170 Authored-by: JB Onofré <jbonofre@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
…ight fail (apache#39171) ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39170 Authored-by: JB Onofré <jbonofre@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
…ight fail (apache#39171) ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39170 Authored-by: JB Onofré <jbonofre@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?