Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39170: [Java] Improve error message explaining why TestTls might fail #39171

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

jbonofre
Copy link
Member

@jbonofre jbonofre commented Dec 11, 2023

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@jbonofre
Copy link
Member Author

jbonofre commented Dec 11, 2023

This closes #39170

@jbonofre jbonofre changed the title Improve error message explaining why TestTls might fail GH-39170: [Java] Improve error message explaining why TestTls might fail Dec 11, 2023
Copy link

⚠️ GitHub issue #39170 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Dec 11, 2023
@jbonofre
Copy link
Member Author

@lidavidm I updated the PR according to your suggestion. Thanks again. This PR is the first one of several coming from me 😄

@lidavidm lidavidm merged commit 7ba0228 into apache:main Dec 11, 2023
16 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Dec 11, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 11, 2023
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 7ba0228.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

mapleFU pushed a commit to mapleFU/arrow that referenced this pull request Dec 13, 2023
…ight fail (apache#39171)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#39170

Authored-by: JB Onofré <jbonofre@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…ight fail (apache#39171)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#39170

Authored-by: JB Onofré <jbonofre@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…ight fail (apache#39171)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#39170

Authored-by: JB Onofré <jbonofre@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Improve error message when Flight Core TestTls fails
2 participants