[GLib] Use Cast() instead of CastTo() #39225
Comments
Progress UpdateRemoving the Legacy Cast broke the tests. |
|
Our C++ API should not throw any exception. Could you find where the exception was thrown? Or I can try it on local later. |
Progress UpdateI have identified the test case that causes the error. arrow/c_glib/test/test-string-scalar.rb Lines 49 to 54 in fc20cd0 |
|
Could you get a backtrace by C++ debugger ( |
|
Is it correct? |
|
Oh... It didn't work... Does this work? diff --git a/c_glib/test/run-test.sh b/c_glib/test/run-test.sh
index 33e9fbf85d..c7bc6edca5 100755
--- a/c_glib/test/run-test.sh
+++ b/c_glib/test/run-test.sh
@@ -34,14 +34,14 @@ for module in "${modules[@]}"; do
module_build_dir="${build_dir}/${module}"
if [ -d "${module_build_dir}" ]; then
LD_LIBRARY_PATH="${module_build_dir}:${LD_LIBRARY_PATH}"
+ DYLD_LIBRARY_PATH="${module_build_dir}:${DYLD_LIBRARY_PATH}"
fi
done
export LD_LIBRARY_PATH
+export DYLD_LIBRARY_PATH
if [ "${BUILD}" != "no" ]; then
- if [ -f "Makefile" ]; then
- make -j8 > /dev/null || exit $?
- elif [ -f "build.ninja" ]; then
+ if [ -f "build.ninja" ]; then
ninja || exit $?
fi
fi
@@ -59,4 +59,19 @@ for module in "${modules[@]}"; do
done
export GI_TYPELIB_PATH
-${GDB} ruby ${test_dir}/run-test.rb "$@"
+if type rbenv > /dev/null 2>&1; then
+ RUBY="$(rbenv which ruby)"
+else
+ RUBY=ruby
+fi
+DEBUGGER_ARGS=()
+case "${DEBUGGER}" in
+ "gdb")
+ DEBUGGER_ARGS+=(--args)
+ ;;
+ "lldb")
+ DEBUGGER_ARGS+=(--one-line "env DYLD_LIBRARY_PATH=${DYLD_LIBRARY_PATH}")
+ DEBUGGER_ARGS+=(--)
+ ;;
+esac
+${DEBUGGER} "${DEBUGGER_ARGS[@]}" "${RUBY}" ${test_dir}/run-test.rb "$@"$ DEBUGGER=lldb BUNDLE_GEMFILE=../c_glib/Gemfile bundle exec ../c_glib/test/run-test.sh -n test_cast |
|
I retried. |
|
Could you run |
|
Yes! |
kou
pushed a commit
that referenced
this issue
Jan 6, 2024
### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for GLib. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: #39225 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this issue
Jan 23, 2024
### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for GLib. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: apache#39225 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for GLib. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: apache#39225 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for GLib. ### Are these changes tested? No. ### Are there any user-facing changes? No. * Closes: apache#39225 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
This is a sub-issue of the issue mentioned below.
I found this through the
ARROW_SUPPRESS_DEPRECATION_WARNINGmacro.arrow/c_glib/arrow-glib/scalar.cpp
Line 388 in dbed728
Component(s)
GLib
The text was updated successfully, but these errors were encountered: