-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Remove Scalar legacy cast implementation #35560
Comments
Hello, I am interested in this issue and looking into it. First, I found functions that are using the legacy I have reorganized these functions to call the
Looking at the table, the calling functions can be organized as follows:
For now, I have submitted a PR for the cases that are working happy case, and I am curious if this aligns with the intentions mentioned in the issue. If PR aligns with the intent, I would like to proceed by separating the happy cases from those that require additional cast implementation, and I would appreciate your feedback. |
Let's create sub issues and use separated PRs! |
Hello @kou Thank you for your response. I've created the issue excluding the happy cases and will first complete the PR for the happy cases. I'm a bit concerned as I have never dealt with compute kernels and have not yet fully finalized the sorting for the dictionary for ChunkedArray and the other issues. However, I've recently had more time to look into Arrow, so I will proceed step by step. |
Thanks! |
…9044) ### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar `CastTo` implementation with the new cast compute kernel for supported types, without requiring additional casting logic for unsupported types. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. * Closes: #35560 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…st (apache#39044) ### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar `CastTo` implementation with the new cast compute kernel for supported types, without requiring additional casting logic for unsupported types. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. * Closes: apache#35560 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the enhancement requested
Let's delete the legacy implementation
Scalar.CastTo()
from Arrow.Arrow has a compute kernel for cast operations that is now included in the base library[1]. PyArrow has migrated Scalar cast usage to this computer kernel[2].
[1] #34295
[2] #35395
Sub issues
Component(s)
C++, Python
The text was updated successfully, but these errors were encountered: