Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Compute] Unsupported cast from binary to fixed-size binary #39232

Closed
pitrou opened this issue Dec 14, 2023 · 0 comments · Fixed by #39236
Closed

[C++][Compute] Unsupported cast from binary to fixed-size binary #39232

pitrou opened this issue Dec 14, 2023 · 0 comments · Fixed by #39236
Assignees
@js8544
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Dec 14, 2023

Describe the enhancement requested

>>> pa.array([b"abc"]).cast(pa.binary(3))
[...]
ArrowNotImplementedError: Unsupported cast from binary to fixed_size_binary using function cast_fixed_size_binary

Component(s)

C++
@github-actions github-actions bot mentioned this issue Dec 15, 2023
Merged
pitrou pushed a commit that referenced this issue Dec 21, 2023
@js8544
GH-39232: [C++] Support binary to fixed_size_binary cast (#39236)
535b925 
### Rationale for this change
Add binary to fixed_size_binary cast.

### What changes are included in this PR?
Add binary to fixed_size_binary cast.

### Are these changes tested?
Yes

### Are there any user-facing changes?
No

* Closes: #39232

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 15.0.0 milestone Dec 21, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@js8544 @clayburn
apacheGH-39232: [C++] Support binary to fixed_size_binary cast (apach…
aeae208 
…e#39236)

### Rationale for this change
Add binary to fixed_size_binary cast.

### What changes are included in this PR?
Add binary to fixed_size_binary cast.

### Are these changes tested?
Yes

### Are there any user-facing changes?
No

* Closes: apache#39232

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@js8544 @dgreiss
apacheGH-39232: [C++] Support binary to fixed_size_binary cast (apach…
8f01956 
…e#39236)

### Rationale for this change
Add binary to fixed_size_binary cast.

### What changes are included in this PR?
Add binary to fixed_size_binary cast.

### Are these changes tested?
Yes

### Are there any user-facing changes?
No

* Closes: apache#39232

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js8544 js8544

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39232: [C++] Support binary to fixed_size_binary cast js8544/arrow
2 participants
@pitrou @js8544