GH-39232: [C++] Support binary to fixed_size_binary cast #39236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pitrou
approved these changes
Dec 21, 2023
| @@ -387,6 +389,33 @@ BinaryToBinaryCastExec(KernelContext* ctx, const ExecSpan& batch, ExecResult* ou | |||
| return ZeroCopyCastExec(ctx, batch, out); | |||
| } | |||
|
|
|||
| template <typename O, typename I> | |||
| enable_if_t<is_base_binary_type<I>::value && std::is_same<O, FixedSizeBinaryType>::value, | |||
There was a problem hiding this comment.
Note that we can use std::is_same_v now.
github-actions
bot
added
awaiting review
pitrou
removed
awaiting review
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 535b925. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…e#39236) ### Rationale for this change Add binary to fixed_size_binary cast. ### What changes are included in this PR? Add binary to fixed_size_binary cast. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#39232 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…e#39236) ### Rationale for this change Add binary to fixed_size_binary cast. ### What changes are included in this PR? Add binary to fixed_size_binary cast. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#39232 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add binary to fixed_size_binary cast.
What changes are included in this PR?
Add binary to fixed_size_binary cast.
Are these changes tested?
Yes
Are there any user-facing changes?
No