Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Default credential authentication #39262

Closed
Tom-Newton opened this issue Dec 17, 2023 · 1 comment · Fixed by #39263
Closed

[C++][FS][Azure] Default credential authentication #39262

Tom-Newton opened this issue Dec 17, 2023 · 1 comment · Fixed by #39263
Assignees
@Tom-Newton
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@Tom-Newton
Copy link
Contributor

Tom-Newton commented Dec 17, 2023 •
edited

Describe the enhancement requested

Child of #38598

Add support for using DefaultAzureCredential to authenticate to Azure blob storage.

https://github.com/Azure/azure-sdk-for-cpp/blob/main/sdk/identity/azure-identity/src/default_azure_credential.cpp

Component(s)

C++
@Tom-Newton Tom-Newton mentioned this issue Dec 17, 2023
Open
2 tasks
@Tom-Newton
Copy link
Contributor Author

take

@github-actions github-actions bot mentioned this issue Dec 17, 2023
Merged
@kou kou mentioned this issue Dec 17, 2023
Closed
kou added a commit that referenced this issue Dec 19, 2023
@Tom-Newton @kou
GH-39262: [C++][Azure][FS] Add default credential auth configuration (#…
659b231 
…39263)

### Rationale for this change
Default credential is a useful auth option. 

### What changes are included in this PR?
Implement `AzureOptions::ConfigureDefaultCredential` plus a little bit of plumbing to go around it. 
Created a simple test. 

### Are these changes tested?
Added a simple unittest that everything initialises happily. This does not actually test a successful authentication. I think to do a real authentication with Azure we would need to run the test against real blob storage and we would need to create various identities which are non-trivial to create. Personally I think this is ok because all the complexity is abstracted away by the Azure SDK. 

### Are there any user-facing changes?

* Closes: #39262

Lead-authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Dec 19, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@Tom-Newton @kou @clayburn
apacheGH-39262: [C++][Azure][FS] Add default credential auth configur…
c87ee55 
…ation (apache#39263)

### Rationale for this change
Default credential is a useful auth option. 

### What changes are included in this PR?
Implement `AzureOptions::ConfigureDefaultCredential` plus a little bit of plumbing to go around it. 
Created a simple test. 

### Are these changes tested?
Added a simple unittest that everything initialises happily. This does not actually test a successful authentication. I think to do a real authentication with Azure we would need to run the test against real blob storage and we would need to create various identities which are non-trivial to create. Personally I think this is ok because all the complexity is abstracted away by the Azure SDK. 

### Are there any user-facing changes?

* Closes: apache#39262

Lead-authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@Tom-Newton @kou @dgreiss
apacheGH-39262: [C++][Azure][FS] Add default credential auth configur…
7da5951 
…ation (apache#39263)

### Rationale for this change
Default credential is a useful auth option. 

### What changes are included in this PR?
Implement `AzureOptions::ConfigureDefaultCredential` plus a little bit of plumbing to go around it. 
Created a simple test. 

### Are these changes tested?
Added a simple unittest that everything initialises happily. This does not actually test a successful authentication. I think to do a real authentication with Azure we would need to run the test against real blob storage and we would need to create various identities which are non-trivial to create. Personally I think this is ok because all the complexity is abstracted away by the Azure SDK. 

### Are there any user-facing changes?

* Closes: apache#39262

Lead-authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Newton Tom-Newton

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39262: [C++][Azure][FS] Add default credential auth configuration Tom-Newton/arrow
2 participants
@kou @Tom-Newton