Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Remove the AzureOptions::backend option #39292

Closed
felipecrv opened this issue Dec 19, 2023 · 0 comments · Fixed by #39293
Closed

[C++] Remove the AzureOptions::backend option #39292

felipecrv opened this issue Dec 19, 2023 · 0 comments · Fixed by #39293

Comments

@felipecrv
Copy link
Contributor

felipecrv commented Dec 19, 2023

Describe the enhancement requested

By adding a more flexible way (URL-based) of determining the backend to use.

Related Issues:

Component(s)

C++

felipecrv added a commit that referenced this issue Dec 19, 2023
…e connection options (#39293)

### Rationale for this change

It's good to avoid mentioning the specific test environment in the implementation code.

### What changes are included in this PR?

 - Removal of the enum
 - Removal of the `AzureOptions::backend` class member
 - Addition of more options to `AzureOptions`
 - Removal of some private string members of `AzureOptions` -- the URLs are built on-the-fly when the clients are instantiated now

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Changes to the public interface (`azurefs.h`) that won't affect users because the `AzureFS` implementation is not used yet.
* Closes: #39292

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@felipecrv felipecrv added this to the 15.0.0 milestone Dec 19, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
…lexible connection options (apache#39293)

### Rationale for this change

It's good to avoid mentioning the specific test environment in the implementation code.

### What changes are included in this PR?

 - Removal of the enum
 - Removal of the `AzureOptions::backend` class member
 - Addition of more options to `AzureOptions`
 - Removal of some private string members of `AzureOptions` -- the URLs are built on-the-fly when the clients are instantiated now

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Changes to the public interface (`azurefs.h`) that won't affect users because the `AzureFS` implementation is not used yet.
* Closes: apache#39292

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…lexible connection options (apache#39293)

### Rationale for this change

It's good to avoid mentioning the specific test environment in the implementation code.

### What changes are included in this PR?

 - Removal of the enum
 - Removal of the `AzureOptions::backend` class member
 - Addition of more options to `AzureOptions`
 - Removal of some private string members of `AzureOptions` -- the URLs are built on-the-fly when the clients are instantiated now

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Changes to the public interface (`azurefs.h`) that won't affect users because the `AzureFS` implementation is not used yet.
* Closes: apache#39292

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant