GH-39292 [C++][FS]: Remove the AzureBackend enum and add more flexible connection options #39293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pitrou
approved these changes
Dec 19, 2023
github-actions
bot
added
awaiting committer review
|
Unrelated failures on macOS and appveyor builds. |
kou
reviewed
Dec 19, 2023
| const std::string& account_name) { | ||
| std::string url; | ||
| url += scheme + "://"; | ||
| if (!authority.empty()) { |
There was a problem hiding this comment.
I think that we should reject empty authority because it builds no host part URL.
There was a problem hiding this comment.
My reasoning here is that there are many validations I could apply, but the most complete validation will come from the error messages triggered by using the filesystem with a bogus URL with 3 slashes after https:.
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 56991d3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…lexible connection options (apache#39293) ### Rationale for this change It's good to avoid mentioning the specific test environment in the implementation code. ### What changes are included in this PR? - Removal of the enum - Removal of the `AzureOptions::backend` class member - Addition of more options to `AzureOptions` - Removal of some private string members of `AzureOptions` -- the URLs are built on-the-fly when the clients are instantiated now ### Are these changes tested? Yes. ### Are there any user-facing changes? Changes to the public interface (`azurefs.h`) that won't affect users because the `AzureFS` implementation is not used yet. * Closes: apache#39292 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…lexible connection options (apache#39293) ### Rationale for this change It's good to avoid mentioning the specific test environment in the implementation code. ### What changes are included in this PR? - Removal of the enum - Removal of the `AzureOptions::backend` class member - Addition of more options to `AzureOptions` - Removal of some private string members of `AzureOptions` -- the URLs are built on-the-fly when the clients are instantiated now ### Are these changes tested? Yes. ### Are there any user-facing changes? Changes to the public interface (`azurefs.h`) that won't affect users because the `AzureFS` implementation is not used yet. * Closes: apache#39292 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's good to avoid mentioning the specific test environment in the implementation code.
What changes are included in this PR?
AzureOptions::backendclass memberAzureOptionsAzureOptions-- the URLs are built on-the-fly when the clients are instantiated nowAre these changes tested?
Yes.
Are there any user-facing changes?
Changes to the public interface (
azurefs.h) that won't affect users because theAzureFSimplementation is not used yet.