Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Client secret authentication #39343

Closed
Tom-Newton opened this issue Dec 21, 2023 · 1 comment · Fixed by #39346
Closed

[C++][FS][Azure] Client secret authentication #39343

Tom-Newton opened this issue Dec 21, 2023 · 1 comment · Fixed by #39346
Assignees
@Tom-Newton
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@Tom-Newton
Copy link
Contributor

Describe the enhancement requested

Child of #38598

Add support for using client secret a.k.a service principal auth. This is basically just user ID and password.

https://github.com/Azure/azure-sdk-for-cpp/blob/main/sdk/identity/azure-identity/src/client_secret_credential.cpp

Component(s)

C++
@Tom-Newton Tom-Newton mentioned this issue Dec 21, 2023
Open
2 tasks
@Tom-Newton Tom-Newton changed the title [C++][FS][Azure] Client secret auth [C++][FS][Azure] Client secret authentication Dec 21, 2023
@Tom-Newton Tom-Newton mentioned this issue Dec 21, 2023
Closed
@Tom-Newton
Copy link
Contributor Author

take

@github-actions github-actions bot mentioned this issue Dec 21, 2023
Merged
@kou kou mentioned this issue Dec 22, 2023
Closed
kou pushed a commit that referenced this issue Dec 22, 2023
@Tom-Newton
GH-39343: [C++][FS][Azure] Add client secret auth configuration (#39346)
929c40b 
### Rationale for this change
Client is a useful Azure authentication

### What changes are included in this PR?
Implement `AzureOptions::ConfigureClientSecretCredential`

### Are these changes tested?
Simple unittest

### Are there any user-facing changes?
Client secret auth is now supported on the Azure filesystem. 

* Closes: #39343

Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Dec 22, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@Tom-Newton @clayburn
apacheGH-39343: [C++][FS][Azure] Add client secret auth configuration (…
24baf03 
…apache#39346)

### Rationale for this change
Client is a useful Azure authentication

### What changes are included in this PR?
Implement `AzureOptions::ConfigureClientSecretCredential`

### Are these changes tested?
Simple unittest

### Are there any user-facing changes?
Client secret auth is now supported on the Azure filesystem. 

* Closes: apache#39343

Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@Tom-Newton @dgreiss
apacheGH-39343: [C++][FS][Azure] Add client secret auth configuration (…
3558163 
…apache#39346)

### Rationale for this change
Client is a useful Azure authentication

### What changes are included in this PR?
Implement `AzureOptions::ConfigureClientSecretCredential`

### Are these changes tested?
Simple unittest

### Are there any user-facing changes?
Client secret auth is now supported on the Azure filesystem. 

* Closes: apache#39343

Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Newton Tom-Newton

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39343: [C++][FS][Azure] Add client secret auth configuration Tom-Newton/arrow
2 participants
@kou @Tom-Newton