Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] platform_tags for macOS were not updated on verification script after increasing minimum version #39656

Closed
raulcd opened this issue Jan 17, 2024 · 0 comments · Fixed by #39657
Closed

[Release] platform_tags for macOS were not updated on verification script after increasing minimum version #39656

raulcd opened this issue Jan 17, 2024 · 0 comments · Fixed by #39657
Assignees
@raulcd
Labels
Component: Release Type: bug
Milestone
15.0.1

Comments

@raulcd
Copy link
Member

raulcd commented Jan 17, 2024

Describe the bug, including details regarding any error messages, version, and platform.

We increased the minimum macOS version to 10.15 and this updated the platform tag for the wheel: #38677

We forgot to update the verification script and this is only checked on the binary verification tasks which failed for 15.0.0 RC1:
https://github.com/ursacomputing/crossbow/actions/runs/7553798910/job/20565612860

We should update the platform tag to be checked on the verification script.

Component(s)

Release
raulcd added a commit to raulcd/arrow that referenced this issue Jan 17, 2024
@raulcd
apacheGH-39656: [Release] Update platform tags for macOS wheels to ma…
2680610 
…cosx_10_15
@github-actions github-actions bot mentioned this issue Jan 17, 2024
Merged
kou pushed a commit that referenced this issue Jan 18, 2024
@raulcd
GH-39656: [Release] Update platform tags for macOS wheels to macosx_1…
1c49b9f 
…0_15 (#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: #39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Jan 18, 2024
@raulcd raulcd modified the milestones: 16.0.0, 15.0.1 Jan 18, 2024
idailylife pushed a commit to idailylife/arrow that referenced this issue Jan 18, 2024
@raulcd @idailylife
apacheGH-39656: [Release] Update platform tags for macOS wheels to ma…
4bac3c8 
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@raulcd @clayburn
apacheGH-39656: [Release] Update platform tags for macOS wheels to ma…
52f5564 
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@raulcd @dgreiss
apacheGH-39656: [Release] Update platform tags for macOS wheels to ma…
7c95c2d 
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
raulcd added a commit that referenced this issue Feb 20, 2024
@raulcd
GH-39656: [Release] Update platform tags for macOS wheels to macosx_1…
ee7f54c 
…0_15 (#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: #39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@raulcd @zanmato1984
apacheGH-39656: [Release] Update platform tags for macOS wheels to ma…
6b60f64 
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@raulcd @thisisnic
apacheGH-39656: [Release] Update platform tags for macOS wheels to ma…
c48bfa9 
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Release Type: bug
Projects
None yet
Milestone
15.0.1
Development

Successfully merging a pull request may close this issue.

GH-39656: [Release] Update platform tags for macOS wheels to macosx_10_15 raulcd/arrow
2 participants
@kou @raulcd