Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39656: [Release] Update platform tags for macOS wheels to macosx_10_15 #39657

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jan 17, 2024

Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

What changes are included in this PR?

Update to the current generated platform tag.

Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.

Copy link

⚠️ GitHub issue #39656 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 17, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We may want to use dev/release/veriry-release-candidate.sh for our wheel related nightly CI jobs.

FYI: We use dev/release/verify-{apt,yum}.sh for our .deb/.rpm related nightly CI jobs.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jan 18, 2024
@kou kou merged commit 1c49b9f into apache:main Jan 18, 2024
6 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jan 18, 2024
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1c49b9f.

There were 2 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

idailylife pushed a commit to idailylife/arrow that referenced this pull request Jan 18, 2024
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
raulcd added a commit that referenced this pull request Feb 20, 2024
…0_15 (#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: #39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
…cosx_10_15 (apache#39657)

### Rationale for this change

Currently the binary verification for releases fails due to wrong macOS platform version.

### What changes are included in this PR?

Update to the current generated platform tag.

### Are these changes tested?

No, but I've validated this is the corrected generated platform tag for the wheels on the Release Candidate: https://apache.jfrog.io/ui/native/arrow/python-rc/15.0.0-rc1/

### Are there any user-facing changes?

Not because of this change but there was a minimum version of macOS as part of the PR that caused this issue.
* Closes: apache#39656

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Release] platform_tags for macOS were not updated on verification script after increasing minimum version
2 participants