Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Top-level Arrow benchmarks should present a items/s or bytes/s metric #39663

Closed
Tracked by #39662
pitrou opened this issue Jan 17, 2024 · 0 comments · Fixed by #40091
Closed
Tracked by #39662

[C++] Top-level Arrow benchmarks should present a items/s or bytes/s metric #39663

pitrou opened this issue Jan 17, 2024 · 0 comments · Fixed by #40091

Comments

@pitrou
Copy link
Member

pitrou commented Jan 17, 2024

Describe the enhancement requested

We should scan through these benchmarks and look for those that only a present an iteration time.
This includes benchmarks for utilities, tensors, IPC, the C Data Interface and (if possible) GPU support.

Component(s)

Benchmarking, C++

pitrou added a commit to pitrou/arrow that referenced this issue Feb 15, 2024
… metrics

Add bytes/second and/or items/second metrics where applicable.
pitrou added a commit that referenced this issue Feb 19, 2024
…cs (#40091)

### Rationale for this change

Some benchmarks may present only an iteration time, or not present sufficiently informative metrics.

### What changes are included in this PR?

Add bytes/second and/or items/second metrics to top-level benchmarks where applicable.

This PR only tackles miscellaneous benchmarks from the top-level Arrow directory, as well as IO, IPC and utilities.

### Are these changes tested?

Manually.

### Are there any user-facing changes?

No.
* Closes: #39663

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 16.0.0 milestone Feb 19, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
… metrics (apache#40091)

### Rationale for this change

Some benchmarks may present only an iteration time, or not present sufficiently informative metrics.

### What changes are included in this PR?

Add bytes/second and/or items/second metrics to top-level benchmarks where applicable.

This PR only tackles miscellaneous benchmarks from the top-level Arrow directory, as well as IO, IPC and utilities.

### Are these changes tested?

Manually.

### Are there any user-facing changes?

No.
* Closes: apache#39663

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
… metrics (apache#40091)

### Rationale for this change

Some benchmarks may present only an iteration time, or not present sufficiently informative metrics.

### What changes are included in this PR?

Add bytes/second and/or items/second metrics to top-level benchmarks where applicable.

This PR only tackles miscellaneous benchmarks from the top-level Arrow directory, as well as IO, IPC and utilities.

### Are these changes tested?

Manually.

### Are there any user-facing changes?

No.
* Closes: apache#39663

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant