-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39663: [C++] Ensure top-level benchmarks present informative metrics #40091
Conversation
… metrics Add bytes/second and/or items/second metrics where applicable.
|
@ursabot please benchmark lang=C++ |
Benchmark runs are scheduled for commit c10547a. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
Thanks for your patience. Conbench analyzed the 1 benchmarking run that has been run so far on PR commit c10547a. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b224c58. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
… metrics (apache#40091) ### Rationale for this change Some benchmarks may present only an iteration time, or not present sufficiently informative metrics. ### What changes are included in this PR? Add bytes/second and/or items/second metrics to top-level benchmarks where applicable. This PR only tackles miscellaneous benchmarks from the top-level Arrow directory, as well as IO, IPC and utilities. ### Are these changes tested? Manually. ### Are there any user-facing changes? No. * Closes: apache#39663 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
… metrics (apache#40091) ### Rationale for this change Some benchmarks may present only an iteration time, or not present sufficiently informative metrics. ### What changes are included in this PR? Add bytes/second and/or items/second metrics to top-level benchmarks where applicable. This PR only tackles miscellaneous benchmarks from the top-level Arrow directory, as well as IO, IPC and utilities. ### Are these changes tested? Manually. ### Are there any user-facing changes? No. * Closes: apache#39663 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
Some benchmarks may present only an iteration time, or not present sufficiently informative metrics.
What changes are included in this PR?
Add bytes/second and/or items/second metrics to top-level benchmarks where applicable.
This PR only tackles miscellaneous benchmarks from the top-level Arrow directory, as well as IO, IPC and utilities.
Are these changes tested?
Manually.
Are there any user-facing changes?
No.