Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archery] archery benchmark diff with JSON inputs broken #39706

Closed
pitrou opened this issue Jan 19, 2024 · 0 comments · Fixed by #39733
Closed

[Archery] archery benchmark diff with JSON inputs broken #39706

pitrou opened this issue Jan 19, 2024 · 0 comments · Fixed by #39733

Comments

@pitrou
Copy link
Member

pitrou commented Jan 19, 2024

Describe the bug, including details regarding any error messages, version, and platform.

$ archery benchmark diff sort-after.json sort-before.json 
Traceback (most recent call last):
  File "/home/antoine/mambaforge/envs/pyarrow/bin/archery", line 33, in <module>
    sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
  File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/antoine/arrow/dev/dev/archery/archery/cli.py", line 628, in benchmark_diff
    conf = CppBenchmarkRunner.default_configuration(
  File "/home/antoine/arrow/dev/dev/archery/archery/benchmark/runner.py", line 120, in default_configuration
    return CppConfiguration(
TypeError: CppConfiguration.__init__() got an unexpected keyword argument 'cpp_benchmark_extras'

This is probably because of #39324

Component(s)

Archery, Benchmarking

@pitrou pitrou self-assigned this Jan 19, 2024
pitrou added a commit to pitrou/arrow that referenced this issue Jan 22, 2024
pitrou added a commit that referenced this issue Jan 22, 2024
### What changes are included in this PR?

This fixes a regression introduced in GH-39303.

### Are these changes tested?

Only manually.

### Are there any user-facing changes?

No.

* Closes: #39706

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 16.0.0 milestone Jan 22, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
### What changes are included in this PR?

This fixes a regression introduced in apacheGH-39303.

### Are these changes tested?

Only manually.

### Are there any user-facing changes?

No.

* Closes: apache#39706

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
### What changes are included in this PR?

This fixes a regression introduced in apacheGH-39303.

### Are these changes tested?

Only manually.

### Are there any user-facing changes?

No.

* Closes: apache#39706

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
### What changes are included in this PR?

This fixes a regression introduced in apacheGH-39303.

### Are these changes tested?

Only manually.

### Are there any user-facing changes?

No.

* Closes: apache#39706

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant