[C++][Parquet] Make BYTE_STREAM_SPLIT routines type-agnostic #39747
Comments
pitrou
added a commit
to pitrou/arrow
that referenced
this issue
Jan 22, 2024
pitrou
added a commit
that referenced
this issue
Jan 23, 2024
#39748) ### Rationale for this change The low-level BYTE_STREAM_SPLIT routines currently reference the logical type they are operating on (float or double). However, the BYTE_STREAM_SPLIT encoding is type-agnostic and only cares about the type width. Removing references to logical types makes these routines easier to reuse. ### Are these changes tested? Yes, including more exhaustive SIMD tests. ### Are there any user-facing changes? No. These routines are internal. * Closes: #39747 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…gnostic (apache#39748) ### Rationale for this change The low-level BYTE_STREAM_SPLIT routines currently reference the logical type they are operating on (float or double). However, the BYTE_STREAM_SPLIT encoding is type-agnostic and only cares about the type width. Removing references to logical types makes these routines easier to reuse. ### Are these changes tested? Yes, including more exhaustive SIMD tests. ### Are there any user-facing changes? No. These routines are internal. * Closes: apache#39747 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
…gnostic (apache#39748) ### Rationale for this change The low-level BYTE_STREAM_SPLIT routines currently reference the logical type they are operating on (float or double). However, the BYTE_STREAM_SPLIT encoding is type-agnostic and only cares about the type width. Removing references to logical types makes these routines easier to reuse. ### Are these changes tested? Yes, including more exhaustive SIMD tests. ### Are there any user-facing changes? No. These routines are internal. * Closes: apache#39747 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
…gnostic (apache#39748) ### Rationale for this change The low-level BYTE_STREAM_SPLIT routines currently reference the logical type they are operating on (float or double). However, the BYTE_STREAM_SPLIT encoding is type-agnostic and only cares about the type width. Removing references to logical types makes these routines easier to reuse. ### Are these changes tested? Yes, including more exhaustive SIMD tests. ### Are there any user-facing changes? No. These routines are internal. * Closes: apache#39747 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
The low-level BYTE_STREAM_SPLIT routines currently reference the logical type they are operating on (float or double). However, the BYTE_STREAM_SPLIT encoding is type-agnostic and only cares about the type width. Removing references to logical types would make these routines easier to reuse.
Component(s)
C++, Parquet
The text was updated successfully, but these errors were encountered: