Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python][Packaging] Remove nightly numpy wheels from the wheel build requirements #39848

Closed
Tracked by #39532
jorisvandenbossche opened this issue Jan 30, 2024 · 5 comments
Closed
Tracked by #39532

[Python][Packaging] Remove nightly numpy wheels from the wheel build requirements #39848

jorisvandenbossche opened this issue Jan 30, 2024 · 5 comments
Assignees
@jorisvandenbossche
Labels
Component: Packaging Component: Python Priority: Blocker Marks a blocker for the release
Milestone
16.0.0

Comments

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jan 30, 2024 •
edited
Loading

#39557 updated the wheel building scripts to install numpy nightly wheels (to have wheels compatible at runtime with numpy nightly). Once there is a stable numpy 2.0 release out (and at the latest before doing the 16.0 release), we should remove that again to ensure we don't build our release wheels with an unstable numpy version.
@jorisvandenbossche jorisvandenbossche mentioned this issue Jan 30, 2024
Closed
8 tasks
@jorisvandenbossche jorisvandenbossche added this to the 16.0.0 milestone Jan 30, 2024
@jorisvandenbossche jorisvandenbossche mentioned this issue Jan 30, 2024
Merged
@rgommers
Copy link

rgommers commented Apr 3, 2024

This can be done now I believe, the numpy>=1.25; python_version>='3.9' requirement can be changed to numpy>=2.0.0rc1; python_version>='3.9'

@raulcd
Copy link
Member

raulcd commented Apr 8, 2024

@jorisvandenbossche should this be done for 16.0.0?

@jorisvandenbossche
Copy link
Member Author

Yes (although I assume that in practice we won't have problems because of building with nightly generally, but that's not a stable thing, so numpy can always accidentally have a bad nightly at some point)

I started working on this yesterday (together with the last item of the numpy 2.0 compat list in #39532), was mostly offline last week.

jorisvandenbossche added a commit to jorisvandenbossche/arrow that referenced this issue Apr 9, 2024
@jorisvandenbossche
apacheGH-39848: [Python][Packaging] Build pyarrow wheels with numpy R…
58805bc 
…C instead of nightly
@github-actions github-actions bot mentioned this issue Apr 9, 2024
Merged
@jorisvandenbossche
Copy link
Member Author

Opened a PR at #41097

kou pushed a commit to jorisvandenbossche/arrow that referenced this issue Apr 10, 2024
@jorisvandenbossche @kou
apacheGH-39848: [Python][Packaging] Build pyarrow wheels with numpy R…
66bf6bc 
…C instead of nightly
raulcd pushed a commit that referenced this issue Apr 15, 2024
@jorisvandenbossche
GH-39848: [Python][Packaging] Build pyarrow wheels with numpy RC inst…
0b33c65 
…ead of nightly (#41097)

### Rationale for this change

Now NumPy has released a first RC for 2.0, we should update our PyArrow wheels to build with this released version instead of with the nightly numpy packages, to ensure we don't build our release wheels with an unstable numpy version.

### What changes are included in this PR?

Increased the version requirement for numpy for the installed packages at build time to `numpy>=2.0.0rc1`, to force installing this RC instead of numpy 1.26

### Are these changes tested?

The wheel tests ensure that those wheels still work with older versions of numpy
* GitHub Issue: #39848

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd
Copy link
Member

raulcd commented Apr 15, 2024

Issue resolved by pull request 41097
#41097

@raulcd raulcd closed this as completed Apr 15, 2024
raulcd pushed a commit that referenced this issue Apr 15, 2024
@jorisvandenbossche @raulcd
GH-39848: [Python][Packaging] Build pyarrow wheels with numpy RC inst…
0d1a016 
…ead of nightly (#41097)

### Rationale for this change

Now NumPy has released a first RC for 2.0, we should update our PyArrow wheels to build with this released version instead of with the nightly numpy packages, to ensure we don't build our release wheels with an unstable numpy version.

### What changes are included in this PR?

Increased the version requirement for numpy for the installed packages at build time to `numpy>=2.0.0rc1`, to force installing this RC instead of numpy 1.26

### Are these changes tested?

The wheel tests ensure that those wheels still work with older versions of numpy
* GitHub Issue: #39848

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@jorisvandenbossche jorisvandenbossche mentioned this issue Apr 15, 2024
Closed
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@jorisvandenbossche @tolleybot
apacheGH-39848: [Python][Packaging] Build pyarrow wheels with numpy R…
7bdc8c5 
…C instead of nightly (apache#41097)

### Rationale for this change

Now NumPy has released a first RC for 2.0, we should update our PyArrow wheels to build with this released version instead of with the nightly numpy packages, to ensure we don't build our release wheels with an unstable numpy version.

### What changes are included in this PR?

Increased the version requirement for numpy for the installed packages at build time to `numpy>=2.0.0rc1`, to force installing this RC instead of numpy 1.26

### Are these changes tested?

The wheel tests ensure that those wheels still work with older versions of numpy
* GitHub Issue: apache#39848

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@jorisvandenbossche @vibhatha
apacheGH-39848: [Python][Packaging] Build pyarrow wheels with numpy R…
9fee884 
…C instead of nightly (apache#41097)

### Rationale for this change

Now NumPy has released a first RC for 2.0, we should update our PyArrow wheels to build with this released version instead of with the nightly numpy packages, to ensure we don't build our release wheels with an unstable numpy version.

### What changes are included in this PR?

Increased the version requirement for numpy for the installed packages at build time to `numpy>=2.0.0rc1`, to force installing this RC instead of numpy 1.26

### Are these changes tested?

The wheel tests ensure that those wheels still work with older versions of numpy
* GitHub Issue: apache#39848

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisvandenbossche jorisvandenbossche

Labels
Component: Packaging Component: Python Priority: Blocker Marks a blocker for the release
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
3 participants
@rgommers @raulcd @jorisvandenbossche