Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Remove the use of pytest-lazy-fixture #39849

Closed
AlenkaF opened this issue Jan 30, 2024 · 0 comments · Fixed by #39850
Closed

[Python] Remove the use of pytest-lazy-fixture #39849

AlenkaF opened this issue Jan 30, 2024 · 0 comments · Fixed by #39850
Assignees
@AlenkaF
Labels
Component: Python
Milestone
15.0.1

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Jan 30, 2024

Describe the bug, including details regarding any error messages, version, and platform.

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0. For now, we have pinned upper version of pytest (see #39827) but we should remove the use of pytest-lazy-fixture as it is unmaintained.

Component(s)

Python
@AlenkaF AlenkaF self-assigned this Jan 30, 2024
@AlenkaF AlenkaF removed the Type: bug label Jan 30, 2024
@github-actions github-actions bot mentioned this issue Jan 30, 2024
Merged
@h-vetinari h-vetinari mentioned this issue Jan 30, 2024
Merged
5 tasks
jorisvandenbossche added a commit that referenced this issue Feb 1, 2024
@AlenkaF @jorisvandenbossche
GH-39849: [Python] Remove the use of pytest-lazy-fixture (#39850)
44d5597 
### Rationale for this change

Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained.
Changes in this PR include:

- Remove the use of `pytest-lazy-fixture`
- Remove marks from fixtures to avoid future error, see
   ```
   PytestRemovedIn9Warning: Marks applied to fixtures have no effect
     See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
   ```
- Catch two different warnings in `def test_legacy_int_type()`

### Are these changes tested?

The changes affect the tests so they must pass.

### Are there any user-facing changes?

No.
* Closes: #39849

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 16.0.0 milestone Feb 1, 2024
@raulcd raulcd modified the milestones: 16.0.0, 15.0.1 Feb 14, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@AlenkaF @jorisvandenbossche @dgreiss
apacheGH-39849: [Python] Remove the use of pytest-lazy-fixture (apach…
7c7db2f 
…e#39850)

### Rationale for this change

Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained.
Changes in this PR include:

- Remove the use of `pytest-lazy-fixture`
- Remove marks from fixtures to avoid future error, see
   ```
   PytestRemovedIn9Warning: Marks applied to fixtures have no effect
     See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
   ```
- Catch two different warnings in `def test_legacy_int_type()`

### Are these changes tested?

The changes affect the tests so they must pass.

### Are there any user-facing changes?

No.
* Closes: apache#39849

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
raulcd pushed a commit that referenced this issue Feb 20, 2024
@AlenkaF @jorisvandenbossche @raulcd
GH-39849: [Python] Remove the use of pytest-lazy-fixture (#39850)
aa172aa 
### Rationale for this change

Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained.
Changes in this PR include:

- Remove the use of `pytest-lazy-fixture`
- Remove marks from fixtures to avoid future error, see
   ```
   PytestRemovedIn9Warning: Marks applied to fixtures have no effect
     See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
   ```
- Catch two different warnings in `def test_legacy_int_type()`

### Are these changes tested?

The changes affect the tests so they must pass.

### Are there any user-facing changes?

No.
* Closes: #39849

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@AlenkaF @jorisvandenbossche @zanmato1984
apacheGH-39849: [Python] Remove the use of pytest-lazy-fixture (apach…
ab55b82 
…e#39850)

### Rationale for this change

Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained.
Changes in this PR include:

- Remove the use of `pytest-lazy-fixture`
- Remove marks from fixtures to avoid future error, see
   ```
   PytestRemovedIn9Warning: Marks applied to fixtures have no effect
     See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
   ```
- Catch two different warnings in `def test_legacy_int_type()`

### Are these changes tested?

The changes affect the tests so they must pass.

### Are there any user-facing changes?

No.
* Closes: apache#39849

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@AlenkaF @jorisvandenbossche @thisisnic
apacheGH-39849: [Python] Remove the use of pytest-lazy-fixture (apach…
ec166c3 
…e#39850)

### Rationale for this change

Removing the use of `pytest-lazy-fixture` in our test suite as it is unmaintained.
Changes in this PR include:

- Remove the use of `pytest-lazy-fixture`
- Remove marks from fixtures to avoid future error, see
   ```
   PytestRemovedIn9Warning: Marks applied to fixtures have no effect
     See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
   ```
- Catch two different warnings in `def test_legacy_int_type()`

### Are these changes tested?

The changes affect the tests so they must pass.

### Are there any user-facing changes?

No.
* Closes: apache#39849

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jelly jelly mentioned this issue Mar 26, 2024
Open
@polyzen polyzen mentioned this issue Mar 26, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: Python
Projects
None yet
Milestone
15.0.1
Development

Successfully merging a pull request may close this issue.

GH-39849: [Python] Remove the use of pytest-lazy-fixture AlenkaF/arrow
3 participants
@raulcd @jorisvandenbossche @AlenkaF